Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

my.cnf: typo fix (bind-address) + migrate key_buffer (deprecated) to key_buffer_size #395

Merged
merged 2 commits into from
Dec 15, 2013
Merged

Conversation

doc75
Copy link
Contributor

@doc75 doc75 commented Dec 14, 2013

Fix a typo in the config file where we can find bind_adress instead of bind-address (cf. https://dev.mysql.com/doc/refman/5.5/en/server-options.html#option_mysqld_bind-address [Option-File Format])

It also change the key_buffer which is deprecated into key_buffer_size (warning issued during installation on Ubuntu 12.04 machine).

@igalic
Copy link
Contributor

igalic commented Dec 14, 2013

I think these should be two separate commits

@doc75
Copy link
Contributor Author

doc75 commented Dec 14, 2013

OK, thanks for the advise, i just did the split of the 2 fixes into 2 commits.
Let me know if you think this still not done properly.

@igalic
Copy link
Contributor

igalic commented Dec 15, 2013

What will happen to existing installations' key_buffer directive?

@doc75
Copy link
Contributor Author

doc75 commented Dec 15, 2013

They will be removed automatically by puppet.
Indeed the file is built with the template my.cnf.erb which is managed in server/config.pp.
In this file you can see that $mysql::server::options is assigned to $options variable, which is then used in the my.cnf.erb template. Therefore the template expansion will contain only the new key and any reference to the old one will be removed by puppet when applying this expanded template.

igalic added a commit that referenced this pull request Dec 15, 2013
my.cnf: typo fix (bind-address) + migrate key_buffer (deprecated) to key_buffer_size
@igalic igalic merged commit 62eb73d into puppetlabs:master Dec 15, 2013
danielfoglio pushed a commit to danielfoglio/puppetlabs-mysql that referenced this pull request Dec 16, 2013
@doc75 doc75 deleted the fixes_my_cnf branch December 26, 2013 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants