Add option so mysql::backup to dump each database to its own file #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…qldump on each database to its own file
apenney
pushed a commit
that referenced
this pull request
Aug 27, 2013
Add option so mysql::backup to dump each database to its own file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a file_per_database parameter to mysql::backup that will modify the mysqlbackup.sh script to loop over all databases and dump each database to it's own file.
Alternatively, a "magic" value for backupdatabases could be used that performs the same changes as file_per_database, something like
backupdatabases => 'each'.Also added rspec-system based tests for the mysql::backup class.