Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysql::db sql parameter support filenames with multiple dots #1505

Merged
merged 3 commits into from
Oct 31, 2022
Merged

mysql::db sql parameter support filenames with multiple dots #1505

merged 3 commits into from
Oct 31, 2022

Conversation

skn-bvdh
Copy link
Contributor

This fixes mysql::db sql parameter to support filenames with multiple dots. #1499

@skn-bvdh skn-bvdh requested a review from a team as a code owner October 25, 2022 13:08
@CLAassistant
Copy link

CLAassistant commented Oct 25, 2022

CLA assistant check
All committers have signed the CLA.

@puppet-community-rangefinder
Copy link

mysql::db is a type

Breaking changes to this file WILL impact these 68 modules (exact match):
Breaking changes to this file MAY impact these 16 modules (near match):

This module is declared in 140 of 579 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@leemachine
Copy link

The change in this PR still does not support absolute filenames that have more than one digit on the directories name.

For example, /opt/app/tmp/app-1.2.3/schema/app.sql

@LukasAud
Copy link
Contributor

Hi @skn-bvdh, your change looks good and it seems like most of our tests are passing fine. However, there seems to be an indentation error that is triggering our Rubocop checks and stopping our Spec tests from running properly.

If you fix that small issue and the tests pass, we should be happy enough to merge this.

@LukasAud
Copy link
Contributor

LGTM. Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants