Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compatibility] Add Raspbian OS to provider configuration #1481

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

jordi-upc
Copy link
Contributor

On Raspbian OS must be defined as provider 'mariadb', otherwise can not install mysql-agent

@jordi-upc jordi-upc requested a review from a team as a code owner July 20, 2022 19:27
@CLAassistant
Copy link

CLAassistant commented Jul 20, 2022

CLA assistant check
All committers have signed the CLA.

@puppet-community-rangefinder
Copy link

mysql::params is a class

Breaking changes to this file WILL impact these 2 modules (exact match):
Breaking changes to this file MAY impact these 1 modules (near match):

This module is declared in 140 of 579 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@LukasAud
Copy link
Contributor

LukasAud commented Aug 1, 2022

Hi @jordi-upc, this is change that we are happy to merge. However, we want to point out that this is only a compatibility change as we do not currently support Raspbian. I will make a small adjustment to the PR title before merging just to avoid any confusion about that topic.

Thanks for your contribution! 👍

@LukasAud LukasAud changed the title Add Raspbian OS to configure provider [Compatibility] Add Raspbian OS to provider configuration Aug 1, 2022
Copy link
Contributor

@LukasAud LukasAud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SLES-15 test failures are unrelated.

@LukasAud LukasAud merged commit 4441ed5 into puppetlabs:main Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants