Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for mariabackup #1447

Merged
merged 1 commit into from
May 27, 2022
Merged

Add support for mariabackup #1447

merged 1 commit into from
May 27, 2022

Conversation

rsynnest
Copy link
Contributor

@rsynnest rsynnest commented Nov 1, 2021

This is a fix for https://tickets.puppetlabs.com/browse/MODULES-11079

The current behavior of this module is to install the percona-xtrabackup package, even if we specify mariabackup as a backupmethod. This PR adds the backupmethod_package param, which allows users to specify the package needed for the backup binary (e.g. for mariabackup, you would specify the mariadb-backup package). An example is also provided in the README in this PR.

@rsynnest rsynnest requested a review from a team as a code owner November 1, 2021 16:32
@CLAassistant
Copy link

CLAassistant commented Nov 1, 2021

CLA assistant check
All committers have signed the CLA.

@puppet-community-rangefinder
Copy link

mysql::params is a class

that may have no external impact to Forge modules.

mysql::server::backup is a class

that may have no external impact to Forge modules.

This module is declared in 140 of 578 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@LukasAud LukasAud closed this Mar 22, 2022
@LukasAud LukasAud reopened this Mar 22, 2022
@puppet-community-rangefinder
Copy link

mysql::params is a class

Breaking changes to this file WILL impact these 2 modules (exact match):
Breaking changes to this file MAY impact these 1 modules (near match):

mysql::server::backup is a class

Breaking changes to this file WILL impact these 4 modules (exact match):

This module is declared in 140 of 579 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@LukasAud LukasAud closed this Apr 25, 2022
@LukasAud LukasAud reopened this Apr 25, 2022
@puppet-community-rangefinder
Copy link

mysql::params is a class

Breaking changes to this file WILL impact these 2 modules (exact match):
Breaking changes to this file MAY impact these 1 modules (near match):

mysql::server::backup is a class

Breaking changes to this file WILL impact these 4 modules (exact match):

This module is declared in 140 of 579 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@LukasAud
Copy link
Contributor

Hi @rsynnest, sorry for the time it took to reply. We have reviewed your PR and it does seem that there are some failures going on through the checks. I believe some of the failures we see have already been addressed and fixed in the latest version of the mySQL module.

Could you rebase your PR and make sure that all automated checks are green? Once that is done, we should be able to properly review and merge your change.

@rsynnest rsynnest force-pushed the main branch 5 times, most recently from b3816a6 to 056fa5b Compare May 27, 2022 06:24
@rsynnest rsynnest changed the title Add support for mariabackup (WIP) Add support for mariabackup May 27, 2022
@rsynnest
Copy link
Contributor Author

This is ready for review. Failed check seems to be a Github Actions timeout issue.

@LukasAud
Copy link
Contributor

LGTM. Thanks for your contribution.

@LukasAud LukasAud merged commit f70708a into puppetlabs:main May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants