Repair check of logbindir

[qha]

Presumably the intention was to check that it is both not relative
and not already managed.

After update to 10.8 the mysql module tries and fails to manage '.'
on nodes where i have log-bin set to a relative path.

[puppet-community-rangefinder]

mysql::server::managed_dirs is a class

that may have no external impact to Forge modules.

This module is declared in 143 of 575 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[gnif]

I can confirm this issue is valid and the fix is correct. I just hit the identical issue.

[qha]

I note that checks fail, i would be willing to put some time into repairing them if someone would provide some starting pointers.

[david22swan]

Closing and re-opening pr in order to force the rekick of the tests. Some of the failures look like they may come from travis

[puppet-community-rangefinder]

mysql::server::managed_dirs is a class

that may have no external impact to Forge modules.

This module is declared in 143 of 576 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[david22swan]

@qha Taking a quick look at the failures, quite a few seem to come from some missing changes.
Could you rebase your changes onto the main, that should clear some of them up and make diagnosis easier.

[qha]

Rebased, hope that does the trick. Thank you for your time and advice! @david22swan

[qha]

Finally figured out at least one reason the tests were failing that was actually a bug (i don't think i introduced it, just changed things up so the tests caught it).

The remaining errors seem to be test environment problems if i understand the output...

[david22swan]

@qha Thanks for responding so fast with the changes 👍
I did a few re-kicks of the tests and their all passing now so I'm happy to merge

[qha]

Thanks for merging! Do you know when a new release might happen? @david22swan

[qha]

I see that a new version has been released now.

[pmcmaw]

Yes apologies, this module has been released as of today and is now available on the Forge!
Thank you for your patience :-) @qha