Handle cron package from different module #1306
Conversation
based on this puppetlabs#1269
Codecov Report
@@ Coverage Diff @@
## master #1306 +/- ##
=======================================
Coverage 50.23% 50.23%
=======================================
Files 22 22
Lines 1045 1045
=======================================
Hits 525 525
Misses 520 520 Continue to review full report at Codecov.
|
|
Hi @ashish1099, this LGTM! Thank you for your contribution! |
| } elsif $::osfamily == 'RedHat' { | ||
| ensure_packages('cronie') | ||
| } elsif $::osfamily != 'FreeBSD' { | ||
| ensure_packages('cron') |
There was a problem hiding this comment.
what does this even do on FreeBSD?
There was a problem hiding this comment.
Hi @igalic, we don't usually test on FreeBSD, so this can be a mistake. I'll have a look! Thank you for highlighting this, feel free to open a PR if you want! Thanks again! Cheers!
There was a problem hiding this comment.
i haven't actually used MySQL since switching to FreeBSD, it's all been SQLite 😅
Backup should only install cron, if one wants it.
based on this #1269