Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix xtrabackup regression introduced in #1207 #1242

Merged
merged 1 commit into from
Oct 15, 2019
Merged

Fix xtrabackup regression introduced in #1207 #1242

merged 1 commit into from
Oct 15, 2019

Conversation

fraenki
Copy link
Contributor

@fraenki fraenki commented Oct 14, 2019

Currently the mysql::backup::xtrabackup class is nonfunctional:

Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Function Call, 
Class[Mysql::Backup::Xtrabackup]: has no parameter named 'backup_success_file_path' 
(file: /etc/puppetlabs/code/environments/development/modules/mysql/manifests/server/backup.pp, line: 98, column: 3) 

This is due to an oversight in #1207, it was forgotten to add the parameter $backup_success_file_path to the manifest (but it was added to the template).

This PR adds the missing parameter $backup_success_file_path.

@fraenki fraenki requested a review from a team as a code owner October 14, 2019 15:53
@fraenki
Copy link
Contributor Author

fraenki commented Oct 15, 2019

The failed test...

Error: Execution of '/usr/bin/mysql --database=mysql -e SET PASSWORD FOR 'root'@'localhost' = '*2470C0C06DEE42FD1618BB99005ADCA2EC9D1E19'' returned 1:

...is NOT caused by this PR :)

@michaeltlombardi michaeltlombardi merged commit c04c1a6 into puppetlabs:master Oct 15, 2019
@fraenki fraenki deleted the fix_xtrabackup branch October 15, 2019 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants