(MODULES-3539) Allow @ in username

[Fogelholk]

Rebase of #1097

Allows having @ in the username (for example 'foo@bar'@'localhost')

If I did it wrong (Sorry, I don't know Github too well), I can scrap my PRs and start over :)

[david22swan]

@Fogelholk No error shown in the adhoc run, but to get this merged it would still need docs changes and test coverage to ensure that people are aware of it and it always works as intended.

[Fogelholk]

I'm not sure how to add test coverage, should I create a new block in puppetlabs-mysql/blob/master/spec/acceptance/types/mysql_user_spec.rb with, for example, the username 'foo@bar@localhost'?

[david22swan]

@Fogelholk That sounds good to me

[Fogelholk]

@david22swan Thanks for all the help so far, I hope I've done everything correctly :)

[david22swan]

@Fogelholk Unfortunately the test's you added have failed against travis. I've posted the error's below:

Failures:
  1) mysql_user using foo@bar@localhost adding user works without errors
     Failure/Error: execute_manifest(pp_three, catch_failures: true)
     Beaker::TestmodeSwitcher::UnacceptableExitCodeError:
       Unacceptable exit code returned: 4. Acceptable code(s): 0, 2
       
     # ./vendor/bundle/ruby/2.5.0/gems/beaker-testmode_switcher-0.4.1/lib/beaker/testmode_switcher/runner_base.rb:31:in `handle_puppet_run_returned_exit_code'
     # ./vendor/bundle/ruby/2.5.0/gems/beaker-testmode_switcher-0.4.1/lib/beaker/testmode_switcher/beaker_runners.rb:138:in `execute_manifest_on'
     # ./vendor/bundle/ruby/2.5.0/gems/beaker-testmode_switcher-0.4.1/lib/beaker/testmode_switcher/beaker_runners.rb:114:in `execute_manifest'
     # ./vendor/bundle/ruby/2.5.0/gems/beaker-testmode_switcher-0.4.1/lib/beaker/testmode_switcher/dsl.rb:13:in `block (2 levels) in <module:DSL>'
     # ./spec/acceptance/types/mysql_user_spec.rb:115:in `block (4 levels) in <top (required)>'
  2) mysql_user using foo@bar@localhost adding user finds the user #stdout
     Failure/Error: expect(r.stdout).to match(%r{^1$})
       expected "" to match /^1$/
       Diff:
       @@ -1,2 +1,2 @@
       -/^1$/
       +""
       
       
     # ./spec/acceptance/types/mysql_user_spec.rb:120:in `block (5 levels) in <top (required)>'
     # ./vendor/bundle/ruby/2.5.0/gems/beaker-4.4.0/lib/beaker/dsl/helpers/host_helpers.rb:93:in `block in on'
     # ./vendor/bundle/ruby/2.5.0/gems/beaker-4.4.0/lib/beaker/shared/host_manager.rb:130:in `run_block_on'
     # ./vendor/bundle/ruby/2.5.0/gems/beaker-4.4.0/lib/beaker/dsl/patterns.rb:37:in `block_on'
     # ./vendor/bundle/ruby/2.5.0/gems/beaker-4.4.0/lib/beaker/dsl/helpers/host_helpers.rb:63:in `on'
     # ./vendor/bundle/ruby/2.5.0/gems/beaker-4.4.0/lib/beaker/dsl/helpers/host_helpers.rb:125:in `shell'
     # ./spec/acceptance/types/mysql_user_spec.rb:119:in `block (4 levels) in <top (required)>'
Finished in 4 minutes 38.3 seconds (files took 1 minute 49.19 seconds to load)
137 examples, 2 failures

[Fogelholk]

@david22swan There we go, I haven't added users with @ in their username before, I had those users created before I added puppet, but it seems to work when I try locally and automatic tests seems happy :)

[david22swan]

@Fogelholk Looks good to me. :)
Thanks for putting the effort in.