Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-8193) - Wrapper methods created for inbuilt 4.x functions #1151

Merged
merged 2 commits into from
Jan 9, 2019
Merged

(MODULES-8193) - Wrapper methods created for inbuilt 4.x functions #1151

merged 2 commits into from
Jan 9, 2019

Conversation

david22swan
Copy link
Member

These were created to bridge the gap between the 4.x and 3.x functions and account for the difference in their naming.

@david22swan
Copy link
Member Author

Tested wrappers by replacing mentions of the actual functions within the code.

@david22swan
Copy link
Member Author

david22swan commented Jan 7, 2019

This pr has been created to allow users to continue to utilize the same function calls after having moved to puppet 4, as the change in naming between the 3.x and 4.x functions would cause breakages for anyone that makes the switch without updating their function calls.

@tphoney
Copy link
Contributor

tphoney commented Jan 8, 2019

Unit tests would be great for this, to show that we at least have the happy path tested.

@tphoney
Copy link
Contributor

tphoney commented Jan 8, 2019

just waiting on the tests .... to finish

@david22swan
Copy link
Member Author

Having some trouble getting the deprecation warning check to work. I've done the wrappers a little differently than how it is in stdlib

@tphoney
Copy link
Contributor

tphoney commented Jan 8, 2019

So these new wrapper functions, are they mentioned in the readme, do they come out when strings is run ?

@david22swan
Copy link
Member Author

Made a strings run, the functions are now in the reference.md.

These were created to bridge the gap between the 4.x and 3.x functions and account for the difference in their naming.
@tphoney
Copy link
Contributor

tphoney commented Jan 9, 2019

@david22swan sorry to point it out

@tphoney tphoney merged commit 8c43386 into puppetlabs:master Jan 9, 2019
@david22swan david22swan deleted the MODULES-8193 branch January 9, 2019 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants