Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GH-1465) Add glossary of bolt terms #2989

Merged
merged 2 commits into from
Sep 1, 2021

Conversation

artlawson
Copy link
Contributor

@artlawson artlawson commented Aug 17, 2021

Add glossary of Bolt terms.

@artlawson artlawson changed the title 1465/glossary (1465) Add glossary of bolt terms Aug 19, 2021
@artlawson artlawson changed the title (1465) Add glossary of bolt terms (GH-1465) Add glossary of bolt terms Aug 19, 2021
@artlawson
Copy link
Contributor Author

One thing I'd like feedback on... I followed what Tom did in the original PR, (and what's common in some other docs) by using Related Information for additional links, but I'm not sure if we'd want to keep this term/format when most terms have associated links. Thoughts?

@artlawson artlawson marked this pull request as ready for review August 19, 2021 19:14
@artlawson artlawson requested review from hestonhoffman and a team as code owners August 19, 2021 19:14
@artlawson
Copy link
Contributor Author

I feel good about the terms collected so far (and hopefully this doc will be updated every once in a while), but are there any terms that I missed that people would find useful?

documentation/glossary.md Outdated Show resolved Hide resolved
@artlawson artlawson linked an issue Aug 19, 2021 that may be closed by this pull request
@artlawson artlawson force-pushed the 1465/glossary branch 2 times, most recently from 3ca471f to e3e1caf Compare August 19, 2021 22:36
@artlawson artlawson force-pushed the 1465/glossary branch 2 times, most recently from b6fcdc1 to 3b85c60 Compare August 19, 2021 22:58
documentation/glossary.md Outdated Show resolved Hide resolved
documentation/glossary.md Outdated Show resolved Hide resolved
documentation/glossary.md Outdated Show resolved Hide resolved
documentation/glossary.md Outdated Show resolved Hide resolved
documentation/glossary.md Outdated Show resolved Hide resolved
documentation/glossary.md Outdated Show resolved Hide resolved
documentation/glossary.md Outdated Show resolved Hide resolved
documentation/glossary.md Outdated Show resolved Hide resolved
documentation/glossary.md Outdated Show resolved Hide resolved
documentation/glossary.md Outdated Show resolved Hide resolved
documentation/glossary.md Outdated Show resolved Hide resolved
Copy link
Contributor

@hestonhoffman hestonhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo edits, but looks good!

documentation/glossary.md Outdated Show resolved Hide resolved
documentation/glossary.md Outdated Show resolved Hide resolved
documentation/glossary.md Outdated Show resolved Hide resolved
@beechtom beechtom merged commit ca0442d into puppetlabs:main Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 'Glossary' page
4 participants