(bug) Allow 'version' key in inventory files #2746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucywyman
force-pushed
the
inventory-version
branch
from
6c60cf6
to
ceaa190
Compare
beechtom
reviewed
Mar 29, 2021
When running `bolt project migrate` we don't remove the `version` key if the value is `2`, but we still raise a warning that the `version` key isn't recognized. This amends the inventoryfile schema to include the `version` key so that users don't see a warning. !bug * **Allow 'version' key in inventory files** Bolt now recognizes the `version` configuration in an inventoryfile and doesn't raise a warning that the key is unknown.
lucywyman
force-pushed
the
inventory-version
branch
from
ceaa190
to
f84db64
Compare
beechtom
approved these changes
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
bolt project migratewe don't remove theversionkey ifthe value is
2, but we still raise a warning that theversionkeyisn't recognized. This amends the inventoryfile schema to include the
versionkey so that users don't see a warning.!bug
Allow 'version' key in inventory files
Bolt now recognizes the
versionconfiguration in an inventoryfileand doesn't raise a warning that the key is unknown.