(bug) Do not warn valid top level inventory config #2742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting `plugin_hooks` as a top level key in `inventory.yaml` is valid (I want to apply the same plugin hook config to every target). Previously a warning that `plugin_hooks` is an "unknown option" when set at the top level of an inventory file was raised. This commit stops that warning by allow listing the setting. !bug * **Do not warn on top level `plugin_hooks` config** Bolt no longer warns that `plugin_hooks` are an unknown option when configured in inventory file.
beechtom
approved these changes
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting
plugin_hooksas a top level key ininventory.yamlis valid (I want to apply the same plugin hook config to every target). Previously a warning thatplugin_hooksis an "unknown option" when set at the top level of an inventory file was raised. This commit stops that warning by allow listing the setting.!bug
Do not warn on top level
plugin_hooksconfigBolt no longer warns that
plugin_hooksare an unknown option when configured in inventory file.