(bug) Correctly compute Cache ID for plugin invocations #2487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we computed a unique cache ID for each plugin invocation based just on the value of `_cache` for the invocation. This meant that any plugin invocations with the same cache `ttl` value would override each other, causing the wrong cached values to be loaded for plugin invocations. We now correctly compute the cache ID to be the plugin invocation hash except for the `_cache` data, so that the same plugin with different cache `ttl` values will load the same data. !bug * **Load the correct data for plugin invocations** Bolt now correctly loads data for the plugin invocation based on the plugin data, not just cache `ttl`. Previously, any plugins with the same cache configuration would collide in the cache data and overwrite each other, causing the wrong data to be loaded.
beechtom
approved these changes
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we computed a unique cache ID for each plugin invocation
based just on the value of
_cachefor the invocation. This meant thatany plugin invocations with the same cache
ttlvalue would overrideeach other, causing the wrong cached values to be loaded for plugin
invocations. We now correctly compute the cache ID to be the plugin
invocation hash except for the
_cachedata, so that the same pluginwith different cache
ttlvalues will load the same data.!bug
Load the correct data for plugin invocations
Bolt now correctly loads data for the plugin invocation based on the
plugin data, not just cache
ttl. Previously, any plugins with thesame cache configuration would collide in the cache data and overwrite
each other, causing the wrong data to be loaded.