(bug) Add 'notice' log level to schema and deprecate #2410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beechtom
force-pushed
the
maint/notice-log-level
branch
from
26ae304
to
898651d
Compare
lucywyman
reviewed
Dec 1, 2020
lucywyman
reviewed
Dec 1, 2020
| @@ -200,6 +204,14 @@ begin | |||
| inventory = Bolt::Config::INVENTORY_OPTIONS.dup | |||
| @transports = Bolt::Config::TRANSPORT_CONFIG.keys | |||
|
|
|||
| # Move sub-options for 'log' option up one level, as they're nested under | |||
| # 'console' and filepath | |||
| @opts['log'][:properties] = @opts['log'][:additionalProperties][:properties] | |||
There was a problem hiding this comment.
I don't see the difference in generated outputs for this? I generated the doc on main and on this branch, and the results were the same...
There was a problem hiding this comment.
Run rake docs:defaults_reference. Without this change running that task on its own will show console instead of level and append in the docs.
This change isn't needed when running rake docs:all since docs:config_reference modifies the options hash first.
This adds the `notice` log level back to the config schema, which was removed in #2098. Because we now use the schema for config validation, the absence of `notice` as a valid option resulted in Bolt raising an error for any user that had that log level configured. Now, Bolt will instead issue a deprecation warning that the log level is deprecated and will be removed in 3.0. !bug * **Support `notice` log level** Log levels can now be set to `notice`. Previously, Bolt would raise an error saying that `notice` was not a supported log level. !deprecation * **Deprecate `notice` log level** The `notice` log level is deprecated and will be removed in Bolt 3.0. Use the `info` log level instead.
beechtom
force-pushed
the
maint/notice-log-level
branch
from
898651d
to
b542fe7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
noticelog level back to the config schema, which wasremoved in #2098. Because we now use the schema for config validation,
the absence of
noticeas a valid option resulted in Bolt raising anerror for any user that had that log level configured. Now, Bolt will
instead issue a deprecation warning that the log level is deprecated and
will be removed in 3.0.
!bug
Support
noticelog levelLog levels can now be set to
notice. Previously, Bolt would raise anerror saying that
noticewas not a supported log level.!deprecation
Deprecate
noticelog levelThe
noticelog level is deprecated and will be removed in Bolt 3.0.Use the
infolog level instead.