Do not check if unrecognized plan parameters are sensitive #1886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beechtom
added a commit
to beechtom/bolt
that referenced
this pull request
Jun 9, 2020
This updates the `run_plan` function to not check if a plan parameter has a `Sensitive` type if the parameter is not recognized by the plan. Previously, if a parameter was passed to a plan that the plan was not expecting, the `run_plan` function would attempt to check the parameter's type expression to determine whether it should be wrapped as `Sensitive`. Since the parameter is unrecognized, it would raise an error when attempting to access its type expression. !bug * **Do not check if unrecognized plan parameters are sensitive** ([puppetlabs#1886](puppetlabs#1886)) The `run_plan` function was attempting to check if unrecognized plan parameters had a `Sensitive` type expression, causing Bolt to raise an unhelpful error. The `run_plan` function no longer checks an unrecognized plan parameter's type.
beechtom
force-pushed
the
bug/unknown-plan-param
branch
from
775d65a
to
ac3f484
Compare
This updates the `run_plan` function to not check if a plan parameter has a `Sensitive` type if the parameter is not recognized by the plan. Previously, if a parameter was passed to a plan that the plan was not expecting, the `run_plan` function would attempt to check the parameter's type expression to determine whether it should be wrapped as `Sensitive`. Since the parameter is unrecognized, it would raise an error when attempting to access its type expression. !bug * **Raise correct error when passing unknown plan parameters** ([puppetlabs#1886](puppetlabs#1886)) Bolt was raising an obscure error when a plan received an unknown parameter. It now raises the correct error indicating that the parameter is unknown.
beechtom
force-pushed
the
bug/unknown-plan-param
branch
from
ac3f484
to
35c8092
Compare
lucywyman
approved these changes
Jun 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
run_planfunction to not check if a plan parameterhas a
Sensitivetype if the parameter is not recognized by the plan.Previously, if a parameter was passed to a plan that the plan was not
expecting, the
run_planfunction would attempt to check theparameter's type expression to determine whether it should be wrapped as
Sensitive. Since the parameter is unrecognized, it would raise anerror when attempting to access its type expression.
!bug
Raise correct error when passing unknown plan parameters (Do not check if unrecognized plan parameters are sensitive #1886)
Bolt was raising an obscure error when a plan received an unknown
parameter. It now raises the correct error indicating that the
parameter is unknown.