(maint) Expand filepaths passed on the CLI relative to cwd #1791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucywyman
force-pushed
the
maint-private-key-path
branch
from
fa0ea16
to
88f6a13
Compare
nicklewis
suggested changes
May 6, 2020
lucywyman
force-pushed
the
maint-private-key-path
branch
from
88f6a13
to
6762a29
Compare
nicklewis
reviewed
May 6, 2020
|
CLA signed by all contributors. |
lucywyman
force-pushed
the
maint-private-key-path
branch
from
6762a29
to
640cffc
Compare
|
There's a test failing now. It looks like the most recent pushed removed an |
As part of the [puppetlabs#1364](puppetlabs#1364) work to standardize how we expand configured paths we expand all paths configured in files relative to the project directory, and stated that all paths set on the CLI would be expanded relative to the directory Bolt was run from. However, only some CLI paths (inventoryfile and puppetfile) were expanded this way, while others (hiera-config and private-key) were expanded relative to the project directory. This standardizes paths passed on the CLI to be expanded relative to the cwd. This is accomplished by expanding the path in our CLI option handler, so that the config object only sees the path as absolute and does not try to expand it relative to the project. !bug * **Expand filepaths passed on the CLI relative to the current working directory** Config options hiera-config and private-key are now expanded relative to the directory Bolt was run from when specified on the CLI, inline with other CLI options.
lucywyman
force-pushed
the
maint-private-key-path
branch
from
640cffc
to
763a60e
Compare
nicklewis
approved these changes
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the #1364 work to
standardize how we expand configured paths we expand all paths
configured in files relative to the project directory, and stated that
all paths set on the CLI would be expanded relative to the directory
Bolt was run from. However, only some CLI paths (inventoryfile and
puppetfile) were expanded this way, while others (hiera-config and
private-key) were expanded relative to the project
directory. This standardizes paths passed on the CLI to be expanded
relative to the cwd. This is accomplished by expanding the path in our
CLI option handler, so that the config object only sees the path as
absolute and does not try to expand it relative to the project.
!bug
Config options hiera-config and private-key are now expanded relative
to the directory Bolt was run from when specified on the CLI, inline
with other CLI options.