Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log file uploads #1256

Closed
nicklewis opened this issue Sep 26, 2019 · 1 comment
Closed

Log file uploads #1256

nicklewis opened this issue Sep 26, 2019 · 1 comment
Assignees
Labels
Feature New features and improvements.

Comments

@nicklewis
Copy link
Contributor

Use Case

Currently, there's no good way to diagnose which files are uploaded by Bolt as part of running a task. They're uploaded to a random directory and deleted after Bolt runs, so you can't look at them on the filesystem. There are also not log messages associated with file uploads for every transport, so you can't check whether Bolt uploaded the right things. This can also lead users to the appearance that Bolt isn't doing the right thing, when it did in fact upload the correct files.

Describe the Solution You Would Like

Each transport should issue debug message for each file that is uploaded, just as it does for each command that is run.

Describe Alternatives You've Considered

Another way to handle this uncertainty about what Bolt is doing would be to add an option to preserve the tempdir after Bolt runs, so that users can log in and inspect it. That would likely require a new CLI flag and would also cause trouble for cases where Bolt creates multiple tempdirs. It also would require Bolt have some clear way to tell users where the tempdir is.

@nicklewis nicklewis added the Feature New features and improvements. label Sep 26, 2019
@donoghuc donoghuc self-assigned this Oct 4, 2019
donoghuc added a commit to donoghuc/bolt that referenced this issue Oct 7, 2019
With this commit a debug log message is produced when a transport uploads a file to a target. Note this excludes the orch transport.
donoghuc added a commit to donoghuc/bolt that referenced this issue Oct 7, 2019
With this commit a debug log message is produced when a transport uploads a file to a target. Note this excludes the orch transport.
donoghuc added a commit to donoghuc/bolt that referenced this issue Oct 7, 2019
With this commit a debug log message is produced when a transport uploads a file to a target. Note this excludes the orch transport.
donoghuc added a commit to donoghuc/bolt that referenced this issue Oct 7, 2019
donoghuc added a commit to donoghuc/bolt that referenced this issue Oct 7, 2019
With this commit a debug log message is produced when a transport uploads a file to a target. Note this excludes the orch transport.
donoghuc added a commit to donoghuc/bolt that referenced this issue Oct 7, 2019
@lucywyman lucywyman assigned lucywyman and unassigned donoghuc Oct 8, 2019
donoghuc added a commit to donoghuc/bolt that referenced this issue Oct 10, 2019
With this commit a debug log message is produced when a transport uploads a file to a target. Note this excludes the orch transport.
donoghuc added a commit to donoghuc/bolt that referenced this issue Oct 10, 2019
donoghuc added a commit that referenced this issue Oct 10, 2019
(GH-1256) Add debug logging for transport file transfer
@donoghuc
Copy link
Member

Closed by #1287

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New features and improvements.
Projects
None yet
Development

No branches or pull requests

3 participants