Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize specifying file paths in bolt config #1162

Closed
donoghuc opened this issue Aug 20, 2019 · 0 comments · Fixed by #1364
Closed

Standardize specifying file paths in bolt config #1162

donoghuc opened this issue Aug 20, 2019 · 0 comments · Fixed by #1364
Assignees
@lucywyman
Labels
Feature New features and improvements.
Milestone
2.0

Comments

@donoghuc
Copy link
Member

donoghuc commented Aug 20, 2019 •
edited
Loading

Use Case

Currently, most config settings are relative to the directory bolt is invoked from (inventoryfile, private-key, etc) while some paths such as modulepath or keys for the pkcs7 plugin are relative to the boltdir. For consistency, relative paths should be standardized.

Describe the Solution You Would Like

When configuration settings point to a file path it should be assumed to be relative to the bolt project directory (Boltdir) unless an absolute path is specified. Do not support the behavior where the user expect the path to be relative to the directory where bolt was invoked.

Make sure to consider when future is available when implementing this.
@donoghuc donoghuc added the Feature New features and improvements. label Aug 20, 2019
@bacongravy bacongravy added the 2.0 label Aug 20, 2019
@adreyer adreyer added this to the 2.0 milestone Sep 25, 2019
@donoghuc donoghuc mentioned this issue Oct 3, 2019
Merged
@lucywyman lucywyman self-assigned this Oct 25, 2019
lucywyman added a commit to lucywyman/bolt that referenced this issue Oct 29, 2019
@lucywyman
(puppetlabsGH-1162) Expand configured paths relative to Boltdir
1c21b77 
There are a number of config options for Bolt that accept filepaths,
both on the CLI and in the config file. Previously we expanded the path
relative to where Bolt was run in some cases, and relative to the
Boltdir in others. This standardizes all configurable paths to be
expanded relative to the Boltdir if they are not already absolute paths.
This provides consistent and predictable behavior for users. New path
expansions are gated on the `future` option being set to `true`.

Closes puppetlabs#1162
@lucywyman lucywyman mentioned this issue Oct 29, 2019
Merged
lucywyman added a commit to lucywyman/bolt that referenced this issue Oct 29, 2019
@lucywyman
(puppetlabsGH-1162) Expand configured paths relative to Boltdir
c82a962 
There are a number of config options for Bolt that accept filepaths,
both on the CLI and in the config file. Previously we expanded the path
relative to where Bolt was run in some cases, and relative to the
Boltdir in others. This standardizes all configurable paths to be
expanded relative to the Boltdir if they are not already absolute paths.
This provides consistent and predictable behavior for users. New path
expansions are gated on the `future` option being set to `true`.

Closes puppetlabs#1162
lucywyman added a commit to lucywyman/bolt that referenced this issue Oct 29, 2019
@lucywyman
(puppetlabsGH-1162) Expand configured paths relative to Boltdir
901763b 
There are a number of config options for Bolt that accept filepaths,
both on the CLI and in the config file. Previously we expanded the path
relative to where Bolt was run in some cases, and relative to the
Boltdir in others. This standardizes all configurable paths to be
expanded relative to the Boltdir if they are not already absolute paths.
This provides consistent and predictable behavior for users. New path
expansions are gated on the `future` option being set to `true`.

Closes puppetlabs#1162
lucywyman added a commit to lucywyman/bolt that referenced this issue Oct 29, 2019
@lucywyman
(puppetlabsGH-1162) Expand configured paths relative to Boltdir
8d46a0e 
There are a number of config options for Bolt that accept filepaths,
both on the CLI and in the config file. Previously we expanded the path
relative to where Bolt was run in some cases, and relative to the
Boltdir in others. This standardizes all configurable paths to be
expanded relative to the Boltdir if they are not already absolute paths.
This provides consistent and predictable behavior for users. New path
expansions are gated on the `future` option being set to `true`.

Closes puppetlabs#1162
lucywyman added a commit to lucywyman/bolt that referenced this issue Oct 29, 2019
@lucywyman
(puppetlabsGH-1162) Expand configured paths relative to Boltdir
58dc1e4 
There are a number of config options for Bolt that accept filepaths,
both on the CLI and in the config file. Previously we expanded the path
relative to where Bolt was run in some cases, and relative to the
Boltdir in others. This standardizes all configurable paths to be
expanded relative to the Boltdir if they are not already absolute paths.
This provides consistent and predictable behavior for users. New path
expansions are gated on the `future` option being set to `true`.

Closes puppetlabs#1162
lucywyman added a commit to lucywyman/puppetlabs-terraform that referenced this issue Oct 29, 2019
@lucywyman
(GH-1162) Expand dir path relative to Boltdir
2f975f2 
As part of standardizing configurable paths to be relative to the
Boltdir (if they're not absolute), the `dir` config is now expanded
relative to the `_boltdir` option that's passed in rather than the
current working directory. Relates to puppetlabs/bolt#1162.
lucywyman added a commit to lucywyman/puppetlabs-terraform that referenced this issue Oct 29, 2019
@lucywyman
(GH-1162) Expand dir path relative to Boltdir
3ccff18 
As part of standardizing configurable paths to be relative to the
Boltdir (if they're not absolute), the `dir` config is now expanded
relative to the `_boltdir` option that's passed in rather than the
current working directory. Relates to puppetlabs/bolt#1162.
lucywyman added a commit to lucywyman/puppetlabs-terraform that referenced this issue Oct 29, 2019
@lucywyman
(GH-1162) Expand dir path relative to Boltdir
89eedaf 
As part of standardizing configurable paths to be relative to the
Boltdir (if they're not absolute), the `dir` config is now expanded
relative to the `_boltdir` option that's passed in rather than the
current working directory. Relates to puppetlabs/bolt#1162.
lucywyman added a commit to puppetlabs/puppetlabs-aws_inventory that referenced this issue Oct 29, 2019
@lucywyman
(GH-1162) Expand credentials filepath relative to Boltdir
12d6b47 
As part of standardizing configurable paths to be relative to the
Boltdir (if they're not absolute), the `credentials` config is now expanded
relative to the `_boltdir` option that's passed in rather than the
current working directory. This is part of the work for
puppetlabs/bolt#1162
@lucywyman lucywyman mentioned this issue Oct 29, 2019
Merged
lucywyman added a commit to lucywyman/bolt that referenced this issue Oct 29, 2019
@lucywyman
(puppetlabsGH-1162) Expand configured paths relative to Boltdir
696b250 
There are a number of config options for Bolt that accept filepaths,
both on the CLI and in the config file. Previously we expanded the path
relative to where Bolt was run in some cases, and relative to the
Boltdir in others. This standardizes all configurable paths to be
expanded relative to the Boltdir if they are not already absolute paths.
This provides consistent and predictable behavior for users. New path
expansions are gated on the `future` option being set to `true`.

Closes puppetlabs#1162
lucywyman added a commit to lucywyman/bolt that referenced this issue Oct 29, 2019
@lucywyman
(puppetlabsGH-1162) Expand configured paths relative to Boltdir
9b1e9b7 
There are a number of config options for Bolt that accept filepaths,
both on the CLI and in the config file. Previously we expanded the path
relative to where Bolt was run in some cases, and relative to the
Boltdir in others. This standardizes all configurable paths to be
expanded relative to the Boltdir if they are not already absolute paths.
This provides consistent and predictable behavior for users. New path
expansions are gated on the `future` option being set to `true`.

Closes puppetlabs#1162
lucywyman added a commit to lucywyman/bolt that referenced this issue Oct 29, 2019
@lucywyman
(puppetlabsGH-1162) Expand configured paths relative to Boltdir
da33f13 
There are a number of config options for Bolt that accept filepaths,
both on the CLI and in the config file. Previously we expanded the path
relative to where Bolt was run in some cases, and relative to the
Boltdir in others. This standardizes all configurable paths to be
expanded relative to the Boltdir if they are not already absolute paths.
This provides consistent and predictable behavior for users. New path
expansions are gated on the `future` option being set to `true`.

Closes puppetlabs#1162
lucywyman added a commit to lucywyman/puppetlabs-terraform that referenced this issue Oct 30, 2019
@lucywyman
(GH-1162) Expand dir path relative to Boltdir
4e1e6ce 
As part of standardizing configurable paths to be relative to the
Boltdir (if they're not absolute), the `dir` config is now expanded
relative to the `_boltdir` option that's passed in rather than the
current working directory. Relates to puppetlabs/bolt#1162.
lucywyman added a commit to lucywyman/bolt that referenced this issue Oct 30, 2019
@lucywyman
(puppetlabsGH-1162) Expand configured paths relative to Boltdir
a782652 
There are a number of config options for Bolt that accept filepaths,
both on the CLI and in the config file. Previously we expanded the path
relative to where Bolt was run in some cases, and relative to the
Boltdir in others. This standardizes all configurable paths to be
expanded relative to the Boltdir if they are not already absolute paths.
This provides consistent and predictable behavior for users. New path
expansions are gated on the `future` option being set to `true`.

Closes puppetlabs#1162
lucywyman added a commit to lucywyman/bolt that referenced this issue Oct 30, 2019
@lucywyman
(puppetlabsGH-1162) Expand configured paths relative to Boltdir
5371760 
There are a number of config options for Bolt that accept filepaths,
both on the CLI and in the config file. Previously we expanded the path
relative to where Bolt was run in some cases, and relative to the
Boltdir in others. This standardizes all configurable paths to be
expanded relative to the Boltdir if they are not already absolute paths.
This provides consistent and predictable behavior for users. New path
expansions are gated on the `future` option being set to `true`.

Closes puppetlabs#1162
lucywyman added a commit to lucywyman/bolt that referenced this issue Oct 30, 2019
@lucywyman
(puppetlabsGH-1162) Expand configured paths relative to Boltdir
a05f05c 
There are a number of config options for Bolt that accept filepaths.
Previously we expanded the path relative to where Bolt was run in some
cases, and relative to the Boltdir in others. This standardizes all
configurable paths to be expanded relative to the Boltdir if they are
defined in a config file, and relative to the current working directory
if they are specified on the CLI. This change doesn't affect absolute
paths.  This provides consistent and predictable behavior for users. New
path expansions are gated on the `future` option being set to `true`.

Closes puppetlabs#1162
lucywyman added a commit to lucywyman/bolt that referenced this issue Oct 31, 2019
@lucywyman
(puppetlabsGH-1162) Expand configured paths relative to Boltdir
986792f 
There are a number of config options for Bolt that accept filepaths.
Previously we expanded the path relative to where Bolt was run in some
cases, and relative to the Boltdir in others. This standardizes all
configurable paths to be expanded relative to the Boltdir if they are
defined in a config file, and relative to the current working directory
if they are specified on the CLI. This change doesn't affect absolute
paths.  This provides consistent and predictable behavior for users. New
path expansions are gated on the `future` option being set to `true`.

Closes puppetlabs#1162
lucywyman added a commit to lucywyman/bolt that referenced this issue Oct 31, 2019
@lucywyman
(puppetlabsGH-1162) Expand configured paths relative to Boltdir
68b052a 
There are a number of config options for Bolt that accept filepaths.
Previously we expanded the path relative to where Bolt was run in some
cases, and relative to the Boltdir in others. This standardizes all
configurable paths to be expanded relative to the Boltdir if they are
defined in a config file, and relative to the current working directory
if they are specified on the CLI. This change doesn't affect absolute
paths.  This provides consistent and predictable behavior for users. New
path expansions are gated on the `future` option being set to `true`.

Closes puppetlabs#1162
lucywyman added a commit to lucywyman/bolt that referenced this issue Oct 31, 2019
@lucywyman
(puppetlabsGH-1162) Expand configured paths relative to Boltdir
6709b4b 
There are a number of config options for Bolt that accept filepaths.
Previously we expanded the path relative to where Bolt was run in some
cases, and relative to the Boltdir in others. This standardizes all
configurable paths to be expanded relative to the Boltdir if they are
defined in a config file, and relative to the current working directory
if they are specified on the CLI. This change doesn't affect absolute
paths.  This provides consistent and predictable behavior for users. New
path expansions are gated on the `future` option being set to `true`.

Closes puppetlabs#1162
lucywyman added a commit to lucywyman/bolt that referenced this issue Oct 31, 2019
@lucywyman
(puppetlabsGH-1162) Expand configured paths relative to Boltdir
871e92d 
There are a number of config options for Bolt that accept filepaths.
Previously we expanded the path relative to where Bolt was run in some
cases, and relative to the Boltdir in others. This standardizes all
configurable paths to be expanded relative to the Boltdir if they are
defined in a config file, and relative to the current working directory
if they are specified on the CLI. This change doesn't affect absolute
paths.  This provides consistent and predictable behavior for users. New
path expansions are gated on the `future` option being set to `true`.

Closes puppetlabs#1162
donoghuc added a commit that referenced this issue Oct 31, 2019
@donoghuc
Merge pull request #1364 from lucywyman/GH-1162
6741379 
(GH-1162) Expand configured paths relative to Boltdir
K8med added a commit to K8med/bolt that referenced this issue Oct 31, 2019
@K8med
Added issue puppetlabs#1162 to the edited Changelog
2c9f467
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucywyman lucywyman

Labels
Feature New features and improvements.
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

(GH-1162) Expand configured paths relative to Boltdir lucywyman/bolt
4 participants
@adreyer @lucywyman @donoghuc @bacongravy