Skip to content
This repository has been archived by the owner on Jun 5, 2020. It is now read-only.

Remove requirement for unique gateway in route table #378

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zvymazal
Copy link

It's an incorrect assumption that there's only one network behind a gateway. It must for example be possible to route several networks through VPN gateway.

24c77282-99fc-11e6-86c2-5b534ab887fe

@hunner
Copy link
Contributor

hunner commented Jan 12, 2017

If you remove this validation and have a route table with multiple gateways, does puppet resource ec2_vpc_routetable report the correct gateways, or does it only report a single gateway? If puppet can't understand multiple gateways somewhere else in the module then this failure could be just to safeguard against other more obscure failures or non-idempotent puppet runs.

Thanks!

@prozach
Copy link
Contributor

prozach commented Feb 10, 2017

@zvymazal Would you mind coming back to address the question here please?

@zvymazal
Copy link
Author

Hi @zleswomp, I believe it behaves correctly with multiple gateways because that's how we used it, but unfortunately I'm not working on that project anymore and cannot confirm on 100%.

@prozach
Copy link
Contributor

prozach commented Feb 10, 2017

This seems like a good change. I don't know how to validate it though.

@daveseff
Copy link
Contributor

daveseff commented May 2, 2018

This may have been taken care of with my PR #505 I had to remove the explicit requirement for the gateway in order to accommodate the peering connections.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants