-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: add commitlint and upgrade husky #86
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a huge fan of the js/angular approach for commit titles (I prefer https://cbea.ms/git-commit/#seven-rules and the 50 chars rule for commit title) but I understand that some tools to generate changelogs and large teams would have a huge benefit from tags and breaking changes meta in the title (unless you forget !
)
Thanks for the review. I've been trialing this format across my JavaScript projects, but we can leave it off Pundit Matchers. Is there a npm package and/or gem to enforce the 7 rules approach? |
Not that I know, but since this is a JS library it makes sense. It looks like commitlint allows to specify rules, but I think it's not worth PS: It appears that dependabot.yml needs a change to meet commit message requirement, as per https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#commit-message |
This is an attempt to make Dependabot meet conventional commit format Refs: - https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#commit-message - #86
This is an attempt to make Dependabot meet conventional commit format Refs: - https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#commit-message - #86
This is an attempt to make Dependabot meet conventional commit format Refs: #86
This is an attempt to make Dependabot meet conventional commit format. Use `build: ` prefix because it is the one used by commitlint itself Refs: #86
This is an attempt to make Dependabot meet conventional commit format. Use `build: ` prefix because it is the one used by commitlint itself Refs: #86
Use conventional commits in this project: https://www.conventionalcommits.org/en/v1.0.0/