Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic test example to readme #53

Merged
merged 1 commit into from
Aug 19, 2023

Conversation

chrisalley
Copy link
Collaborator

@chrisalley chrisalley commented Aug 9, 2023

I will look at doing a 0.2.0 release once this is merged in, and add matchers (#44) as a later release.

@chrisalley chrisalley requested a review from johno August 9, 2023 09:20
@chrisalley
Copy link
Collaborator Author

@johno Was there a 0.1.0 tag created (e.g. on your local machine) that can be pushed up? It's not showing as a tag in git, but there's a release in npm.

@chrisalley chrisalley force-pushed the add-basic-test-example-to-readme branch from 4102ade to 179c60b Compare August 9, 2023 09:30
@chrisalley
Copy link
Collaborator Author

@johno Was there a 0.1.0 tag created (e.g. on your local machine) that can be pushed up? It's not showing as a tag in git, but there's a release in npm.

I found the v0.1.0 commit and added the tag to it myself. Are we able to merge the outstanding PRs @johno?

@chrisalley
Copy link
Collaborator Author

@tagliala if you're willing/interested, there's some PRs that need reviewing for this WIP JavaScript implementation of Pundit that we've been developing.

@chrisalley chrisalley merged commit 1a261ef into main Aug 19, 2023
3 checks passed
@chrisalley chrisalley deleted the add-basic-test-example-to-readme branch August 19, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants