Upgrade terraform-provider-keycloak to v4.1.0 #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwahbe
requested review from
guineveresaenger and
jazzyfresh
and removed request for
jazzyfresh and
guineveresaenger
iwahbe
force-pushed
the
iwahbe/upgrade-terraform-provider-keycloak-to-v4.1.0
branch
3 times, most recently
from
424f4ee
to
dbcda5f
Compare
This is a major version upgrade.
iwahbe
force-pushed
the
iwahbe/upgrade-terraform-provider-keycloak-to-v4.1.0
branch
from
dbcda5f
to
d5f6b0b
Compare
iwahbe
force-pushed
the
iwahbe/upgrade-terraform-provider-keycloak-to-v4.1.0
branch
from
3d2e60b
to
f531530
Compare
iwahbe
force-pushed
the
iwahbe/upgrade-terraform-provider-keycloak-to-v4.1.0
branch
from
f531530
to
68afc06
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. New resources:
New functions:
|
iwahbe
force-pushed
the
iwahbe/upgrade-terraform-provider-keycloak-to-v4.1.0
branch
from
68afc06
to
6ba39a0
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. New resources:
New functions:
|
That sounds good thank you. You'll need to edit ci-mgmt and re-sync it back here, I'd appreciate that, because that sets us up for success in the near future for automated PRs from ci-mgmt that mass-update providers not to wipe the changes here. |
iwahbe
deleted the
iwahbe/upgrade-terraform-provider-keycloak-to-v4.1.0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #158
Fixes #155
Fixes #153
To get the tests working, I changed the value of
KEYCLOAK_URLfromhttp://localhost:8080tohttp://localhost:8080/auth. After this PR merges, I'm going to follow up with a PR to ci-mgmt.