Create example for testing parallel ECS updates #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flostadler
commented
Jul 2, 2024
| @@ -201,6 +202,24 @@ func TestVpcMultipleSimilarSubnetSpecArgs(t *testing.T) { | |||
| integration.ProgramTest(t, &test) | |||
| } | |||
|
|
|||
| func TestAccEcsParallel(t *testing.T) { | |||
| maxDuration(15*time.Minute, t, func(t *testing.T) { | |||
There was a problem hiding this comment.
Deploying and updating 10 of these ECS services took 1+ hours before. Now that it's all parallel it runs in under 10min
flostadler
changed the title
corymhall
approved these changes
Jul 2, 2024
Generally I agree with you, but this aspect of pu/pu is under-tested right now. I tried adding some tests for this area (provider server) there, but this would've required to refactor the provider server, which would be quite the rabbit hole. |
|
/release minor |
|
This PR has been shipped in release v2.13.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an example to test parallel updates to components like ECS services. Currently component updates are serialized (#1250), but pulumi/pulumi#7629 fixed that.
I used this test for verifying the changes locally, now that the change is released we can use this as a regression test