Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add BOX86_RCFILE support #960

Merged
merged 2 commits into from
Apr 30, 2024
Merged

feat: add BOX86_RCFILE support #960

merged 2 commits into from
Apr 30, 2024

Conversation

shenmo7192
Copy link
Contributor

Try to make box86 support _RCFILE env like box64
https://github.com/ptitSeb/box64/blob/main/src/core.c#L1595

@shenmo7192 shenmo7192 mentioned this pull request Apr 30, 2024
Closed
ptitSeb
ptitSeb reviewed Apr 30, 2024
View reviewed changes
src/main.c Outdated Show resolved Hide resolved
ptitSeb
ptitSeb requested changes Apr 30, 2024
View reviewed changes
Copy link
Owner

@ptitSeb ptitSeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to comment the else LoadRCFile(NULL); as box86 does not have a default in-memory RCFile handling.

shenmo7192
shenmo7192 commented Apr 30, 2024
View reviewed changes
Copy link
Contributor Author

@shenmo7192 shenmo7192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented

src/main.c Outdated Show resolved Hide resolved
@ptitSeb ptitSeb merged commit f5f1e14 into ptitSeb:master Apr 30, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptitSeb ptitSeb ptitSeb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shenmo7192 @ptitSeb