Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in schedule #110

Closed
chevcheli0s opened this issue Oct 21, 2021 · 8 comments
Closed

Bug in schedule #110

chevcheli0s opened this issue Oct 21, 2021 · 8 comments

Comments

@chevcheli0s
Copy link

chevcheli0s commented Oct 21, 2021

Describe the bug
I started butler-cw with parameter "freq: at 11:15 am" in config.
Bug 1 - Warming cache started immediately
Bug 2 - It use UTC time(in logs too), not local (maybe it is feature?)

To Reproduce
Use parameter "freq: at 11:15 am" in config

Expected behavior

  1. Start according to schedule.
  2. Use local time(?)

Describe environment:

  • OS: Debian 10
  • Containerisation no
  • Version of Butler CW 3.1.1

Config file(s)
...
freq: at 11:15 am

@mountaindude
Copy link
Collaborator

Thx for reporting this.

I noticed myself that latest version of the scheduler acts funky/not as expected.

Might be that some bug was introduced in that last upgrade. In theory upgrading to latest version of software modules should remove bugs, not add new ones... But that's in theory, we're dealing with reality, of course.
Will look into that a bit more.

Re your bug 1, it's actually normal behaviour.
I realise it's not really (at all?) documented... but there is a cache warming done for each app when Butler CW is started.
While that's useful at times, it should be configurable.
I've added a new ticket about this: #111

Re bug 2 I am not sure if it's UTC or not.. Will have a look and report back.

@mountaindude
Copy link
Collaborator

@chevcheli0s

FYI, I've decided to refactor the entire scheduler part of Butler CW.
First phase (v3.2) will just be an incremental, backwards compatible upgrade.
Next phase (v4.0) will include breaking changes, but also deliver way more powerful and flexible scheduling (cron schedules, text schedules and more).

@mountaindude
Copy link
Collaborator

@chevcheli0s

Version 3.2 has been released, available on the release page.

It adds a per-app flag that controls whether the app should be loaded on Butler CW startup or not.
It also optionally (controlled by setting in main config file) shows the first few cache warming runs for each app.

@mountaindude
Copy link
Collaborator

Btw, local time is used for scheduling.

Will add setting to control this in next version, see #115.

@chevcheli0s
Copy link
Author

Thanks for v.3.2!
It is strange but in my case, when I run "journalctl -u butler-cw -f" I see that
image
my local time UTC+3
In the logs - UTC time and scheduler use the same.
That is why I need to use in config "freq: at 08:15 am" instead of "freq: at 11:15 am"

@mountaindude
Copy link
Collaborator

mountaindude commented Oct 21, 2021 via email

@mountaindude mountaindude reopened this Oct 21, 2021
@mountaindude
Copy link
Collaborator

We should just suggest to the UN that all countries switch to UTC...

I think there are two things at play here:

  • The format in which you enter a schedule. UTC or local.
  • The format used to display info about coming caching runs. UTC or local.

Maybe it's best to just expose both as options in the config file.. Not sure why you'd NOT want them to be the same though.
But as always - flexibility with sane defaults is usually a good thing.

@mountaindude
Copy link
Collaborator

Update on the bugs reported in the first entry in this thread.

Bug 1: Tracked in #111. Implemented in version 3.2.0.
Bug 2: Tracked in #115. Will be included in v4.0.0.

With that, this ticket is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants