Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open html file in browser (iframe viewer) #177

Closed
FabriceBoyer opened this issue May 5, 2017 · 8 comments
Closed

Open html file in browser (iframe viewer) #177

FabriceBoyer opened this issue May 5, 2017 · 8 comments
Assignees
Milestone

Comments

@FabriceBoyer
Copy link

FabriceBoyer commented May 5, 2017

Hi,

When I click on an html file item in RichFilemanager, I'd like it to open in the same browser.
At present time, it opens a "preview" view showing only an icon.

I don't want to edit the html, just see it as if I had double clicked on it in Windows Explorer. Clicking "Back" in browser should bring me back to list of HTML files in RichFilemanager.

I tried playing with several configuration options (in filemanager.init.js, filemanager.config.json and config.php) but couldn't get anything to work. Any idea how to achieve this behaviour ?

I'm using PHP with Nginx and default RichFilemanager configuration.

Regards,
Fabrice

@psolom
Copy link
Owner

psolom commented May 5, 2017

Yeap, there is no such capability for html files at the moment. I will think about it.

@FabriceBoyer
Copy link
Author

It would help a lot !
Thanks for your great work

psolom added a commit that referenced this issue May 5, 2017
@psolom
Copy link
Owner

psolom commented May 5, 2017

Checkout updated master branch. I have made previewer for html/htm files via iframe, see new viewer.iframe options section in the JSON configuration file. It works in the same way (no new windows opened), but instead of preview item you will see html page loaded in iframe. As a bonus I have made html files editable by default, so now you can preview and edit html/htm files at the preview page.

NOTES: Not uploaded to the demo page. Going to release in v2.4.0

@psolom psolom self-assigned this May 5, 2017
@psolom psolom added this to the 2.4.0 milestone May 5, 2017
@FabriceBoyer
Copy link
Author

Thanks a lot, it looks like exactly what i needed !
I'll test that as soon as I'm back from my trip, I didn't expect such a fast feedback, that's really great !

@psolom
Copy link
Owner

psolom commented May 6, 2017

You are welcome. Looking forward for your feedback.

@psolom psolom changed the title Open html file in browser Open html file in browser (iframe viewer) May 6, 2017
@psolom
Copy link
Owner

psolom commented May 7, 2017

Released in v2.4.0
I close this issue, but still interested in your feedback. Also report if you will face any bugs, please.

@psolom psolom closed this as completed May 7, 2017
@FabriceBoyer
Copy link
Author

Hi,

Sorry for delayed response. I've tested your changes and it works great. Good job!
Thanks again

@psolom
Copy link
Owner

psolom commented May 15, 2017

You are welcome. Thanks for the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants