Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and speedup diff-shades integration #2773

Merged
merged 6 commits into from
Jan 20, 2022
Merged

Fix and speedup diff-shades integration #2773

merged 6 commits into from
Jan 20, 2022

Commits on Jan 14, 2022

  1. Security + a bit more tweaking + concurrency limits

    @ichard26
    ichard26 committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    8f5de59 View commit details
    Browse the repository at this point in the history

  2. Work around empty field in GH API on PRs from forks

    @ichard26
    ichard26 committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    90a5ec4 View commit details
    Browse the repository at this point in the history

  3. Compile baseline/target revisions w/ mypyc 

    Should help cut runtime by 20-45% :fingers_crossed:
    @ichard26
    ichard26 committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    f697d83 View commit details
    Browse the repository at this point in the history

  4. mypyc: fix runtime type violation 

    `normalized` is typed as str which is a problem as the fallback assigns
`value` to `normalized` which can be anything. This wasn't caught
statically because `value` is typed as Any which effectively disables
type checking.
    @ichard26
    ichard26 committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    cdea55b View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2022

  1. ... does this help with compile time / analysis runtime

    @ichard26
    ichard26 committed Jan 15, 2022
    Configuration menu
    Copy the full SHA
    4829505 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2022

  1. Merge branch 'main' into diff-shades-v2

    @JelleZijlstra
    JelleZijlstra committed Jan 17, 2022
    Configuration menu
    Copy the full SHA
    3209745 View commit details
    Browse the repository at this point in the history