Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hidden import from PyInstaller build #2657

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

jalaziz
Copy link
Contributor

@jalaziz jalaziz commented Nov 29, 2021

Description

The recent 2021.4 release of pyinstaller-hooks-contrib now contains a
built-in hook for platformdirs. Manually specifying the hidden import
arg should no longer be needed.

The latest release of pyinstaller-hooks-contrib is installed when installing
PyInstaller, so reverting #2466 is all that is needed.

Checklist - did you ...

  • Add a CHANGELOG entry if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?

I did not add a changelog entry for this as there should be no change in behavior to the end user.

The recent 2021.4 release of pyinstaller-hooks-contrib now contains a
built-in hook for platformdirs. Manually specifying the hidden import
arg should no longer be needed.
@JelleZijlstra JelleZijlstra added the skip news Pull requests that don't need a changelog entry. label Nov 29, 2021
Copy link
Collaborator

@ichard26 ichard26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for keeping tabs on this mate! Always nice to simply the CD pipeline so it has less room to break in an already chaotic time.

Copy link
Collaborator

@cooperlees cooperlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome - Thanks!

Did you test we got functioning executable binaries from this PR? Should just be able to run it on respective platforms right?

@jalaziz
Copy link
Contributor Author

jalaziz commented Nov 30, 2021

Awesome - Thanks!

Did you test we got functioning executable binaries from this PR? Should just be able to run it on respective platforms right?

I tested the macOS binary, but also confirmed that the hooks were being picked up on all the platforms based on the logs.

@cooperlees
Copy link
Collaborator

Thanks. Sounds good to me then!

@cooperlees cooperlees merged commit e151686 into psf:main Nov 30, 2021
@jalaziz jalaziz deleted the pyinstaller-update branch December 1, 2021 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news Pull requests that don't need a changelog entry.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants