Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate msgfees gov props v1 #1627

Merged

Conversation

nullpointer0x00
Copy link
Contributor

@nullpointer0x00 nullpointer0x00 commented Jul 11, 2023

Description

closes: #1328


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@nullpointer0x00 nullpointer0x00 added the msgfees Msg based fee module label Jul 11, 2023
@nullpointer0x00 nullpointer0x00 added this to the v1.17.0 milestone Jul 11, 2023
@nullpointer0x00 nullpointer0x00 self-assigned this Jul 11, 2023
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #1627 (d026706) into main (60edc7d) will increase coverage by 0.11%.
Report is 2 commits behind head on main.
The diff coverage is 78.08%.

❗ Current head d026706 differs from pull request most recent head da7d7ab. Consider uploading reports for the commit da7d7ab to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1627      +/-   ##
==========================================
+ Coverage   63.81%   63.93%   +0.11%     
==========================================
  Files         223      223              
  Lines       28599    28813     +214     
==========================================
+ Hits        18251    18422     +171     
- Misses       9156     9194      +38     
- Partials     1192     1197       +5     
Files Changed Coverage Δ
x/attribute/keeper/keeper.go 77.65% <ø> (+0.21%) ⬆️
x/marker/keeper/marker.go 55.53% <ø> (-0.51%) ⬇️
x/msgfees/types/codec.go 0.00% <0.00%> (ø)
app/upgrades.go 63.58% <66.66%> (+4.69%) ⬆️
x/msgfees/types/msgs.go 66.46% <66.66%> (-20.38%) ⬇️
app/app.go 83.44% <100.00%> (ø)
x/msgfees/keeper/keeper.go 73.33% <100.00%> (+0.66%) ⬆️
x/msgfees/keeper/msg_server.go 100.00% <100.00%> (ø)
x/msgfees/keeper/proposal_handler.go 66.66% <100.00%> (ø)

@nullpointer0x00 nullpointer0x00 marked this pull request as ready for review August 1, 2023 18:22
@nullpointer0x00 nullpointer0x00 requested a review from a team as a code owner August 1, 2023 18:22
@nullpointer0x00 nullpointer0x00 enabled auto-merge (squash) August 1, 2023 18:36
Taztingo
Taztingo previously approved these changes Aug 11, 2023
@nullpointer0x00 nullpointer0x00 merged commit 713e397 into main Aug 11, 2023
35 checks passed
@nullpointer0x00 nullpointer0x00 deleted the nullpointer0x00/1328-migrate-msgfees-gov-props-v1 branch August 11, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
msgfees Msg based fee module
Projects
Development

Successfully merging this pull request may close these issues.

Migrate msgfees gov props to v1.
4 participants