Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed ibc-go dependency, and updated code to route messages to the … #1618

Merged
merged 10 commits into from
Jul 13, 2023

Conversation

Taztingo
Copy link
Contributor

@Taztingo Taztingo commented Jul 5, 2023

Description

Removes our dependency on a forked version of ibc-go, and updates the Marker module to use MsgTransfer to send an IBC Transfer.

closes: #1616


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #1618 (261d826) into main (59f2f47) will increase coverage by 0.02%.
The diff coverage is 22.22%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1618      +/-   ##
==========================================
+ Coverage   63.58%   63.61%   +0.02%     
==========================================
  Files         223      223              
  Lines       28372    28360      -12     
==========================================
  Hits        18041    18041              
+ Misses       9144     9132      -12     
  Partials     1187     1187              
Impacted Files Coverage Δ
x/marker/keeper/marker.go 56.04% <0.00%> (+0.45%) ⬆️
x/marker/keeper/msg_server.go 31.53% <0.00%> (+0.36%) ⬆️
app/app.go 83.44% <100.00%> (ø)
x/marker/keeper/keeper.go 85.48% <100.00%> (ø)

@Taztingo Taztingo self-assigned this Jul 5, 2023
@Taztingo Taztingo added the ibc inter-blockchain communication label Jul 5, 2023
@Taztingo Taztingo added this to the v1.17.0 milestone Jul 5, 2023
@Taztingo Taztingo marked this pull request as ready for review July 7, 2023 13:37
@Taztingo Taztingo requested a review from a team as a code owner July 7, 2023 13:37
@Taztingo Taztingo enabled auto-merge (squash) July 7, 2023 16:10
iramiller
iramiller previously approved these changes Jul 12, 2023
@Taztingo Taztingo requested a review from iramiller July 13, 2023 13:34
@Taztingo Taztingo merged commit cf2b2c2 into main Jul 13, 2023
40 of 41 checks passed
@Taztingo Taztingo deleted the taztingo/1616-remove-ibc-go-dependency branch July 13, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ibc inter-blockchain communication
Projects
Development

Successfully merging this pull request may close these issues.

Remove ibc-go fork dependency
3 participants