-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add page for chain versions #208
Comments
NOTE: we may abandon |
@minxylynx for bullet two, instead of adding a page for each stat, what about matching a similar construct to the dashboard view, that allows a user to scroll up/down and view all stats on one page |
I agree that abandoning the "initial version" ... and going with "Recommended Version" makes the most sense here... in some cases (such as early 1.7.x releases) the initial version(s) should not be used at all... |
The skipped part could be a bit more clear as well ... perhaps if the line was in strikethrough italics that would help? Perhaps with one of those info hovers that indicates the upgrade height should be skipped ... but even if they tried to run that upgrade using the recommended 1.7.6 version it would actually halt immediately and tell them to skip the upgrade height Combining "recommended versions" with a more obvious |
@jarrydallison ehh, Maybe for now its fine (with just the upgrades on the stats page), but ideally we add additional stats related to gas usage / fees as well as param sets for the chain. Adding all different types of stats to one page can get confusing |
@iramiller @jarrydallison I agree on "Recommended Version" instead of both "Initial" and "Current" columns. How about consolidating the "Skipped" and "Scheduled" columns into one column that shows "Skipped" (with a clickable info icon that shows how to skip that upgrade) or "Scheduled". Maybe have fancy text for each, but dunno what. Also, could ask @webbushka about the color Hexcodes... maybe we could use those somehow. |
@minxylynx @iramiller I believe I've implemented all the comments you've posted. Take a look and let me know what you think. I've combined the skipped/scheduled into one 'Events' column, that will display skipped or scheduled depending on what's in the /upgrades response. Additionally, the info icon displays the instructions that Ira sent to me when you hover over it. Stats in the Nav Bar is now a dropdown menu. |
Summary
Add a page that holds the current list of versions and info against the chain.
Problem Definition
Proposal
Stats
top bar menu itemVersions
under Stats/api/v2/chain/upgrades
API, add a table showing:not yet applied - will be applied at upgrade height
API response:
For Admin Use
The text was updated successfully, but these errors were encountered: