Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add page for chain versions #208

Closed
9 of 13 tasks
minxylynx opened this issue Dec 13, 2021 · 7 comments · Fixed by #210
Closed
9 of 13 tasks

Feature: Add page for chain versions #208

minxylynx opened this issue Dec 13, 2021 · 7 comments · Fixed by #210
Assignees
Labels
enhancement New feature or request page Update or add a new/existing page
Milestone

Comments

@minxylynx
Copy link
Collaborator

minxylynx commented Dec 13, 2021

Summary

Add a page that holds the current list of versions and info against the chain.

Problem Definition

Proposal

  • Add Stats top bar menu item
  • Add page Versions under Stats
  • Using /api/v2/chain/upgrades API, add a table showing:
    • Upgrade Height
    • Upgrade Name
    • Initial version -> info defining initial as the one submitted with the upgrade proposal
    • Current Version -> current patch version that can be applied at this upgrade height
    • Skipped -> show a checkmark or something denoting it skipped, info defining it like this https://github.com/provenance-io/testnet/blob/main/README.md?plain=1#L48
    • Schedules -> show a checkmark or something denoting it scheduled, info defining scheduled as not yet applied - will be applied at upgrade height

API response:

[
  {
      "upgradeHeight": 0,
      "upgradeName": "Genesis",
      "definedVersion": "v0.2.0",
      "currentPatchVersion": "v0.2.1",
      "skipped": false,
      "scheduled": false
    }
]

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@minxylynx
Copy link
Collaborator Author

NOTE: we may abandon Initial Version because the Current Version should be the one people use out of the gate.

@jarrydallison jarrydallison self-assigned this Dec 13, 2021
@webbushka webbushka added enhancement New feature or request page Update or add a new/existing page labels Dec 15, 2021
@webbushka webbushka added this to the 2.3.0 milestone Dec 15, 2021
@jarrydallison
Copy link
Contributor

@minxylynx for bullet two, instead of adding a page for each stat, what about matching a similar construct to the dashboard view, that allows a user to scroll up/down and view all stats on one page
Screen Shot 2021-12-16 at 2 23 46 PM
?

@iramiller
Copy link
Member

I agree that abandoning the "initial version" ... and going with "Recommended Version" makes the most sense here... in some cases (such as early 1.7.x releases) the initial version(s) should not be used at all...

@iramiller
Copy link
Member

The skipped part could be a bit more clear as well ... perhaps if the line was in strikethrough italics that would help? Perhaps with one of those info hovers that indicates the upgrade height should be skipped ... but even if they tried to run that upgrade using the recommended 1.7.6 version it would actually halt immediately and tell them to skip the upgrade height

Combining "recommended versions" with a more obvious abandoned version should be really easy to follow.

@minxylynx
Copy link
Collaborator Author

@jarrydallison ehh, Maybe for now its fine (with just the upgrades on the stats page), but ideally we add additional stats related to gas usage / fees as well as param sets for the chain. Adding all different types of stats to one page can get confusing

@minxylynx
Copy link
Collaborator Author

The skipped part could be a bit more clear as well ... perhaps if the line was in strikethrough italics that would help? Perhaps with one of those info hovers that indicates the upgrade height should be skipped ... but even if they tried to run that upgrade using the recommended 1.7.6 version it would actually halt immediately and tell them to skip the upgrade height

Combining "recommended versions" with a more obvious abandoned version should be really easy to follow.

@iramiller @jarrydallison I agree on "Recommended Version" instead of both "Initial" and "Current" columns.

How about consolidating the "Skipped" and "Scheduled" columns into one column that shows "Skipped" (with a clickable info icon that shows how to skip that upgrade) or "Scheduled". Maybe have fancy text for each, but dunno what. Also, could ask @webbushka about the color Hexcodes... maybe we could use those somehow.

@jarrydallison
Copy link
Contributor

jarrydallison commented Dec 22, 2021

@minxylynx @iramiller I believe I've implemented all the comments you've posted. Take a look and let me know what you think.
Screen Shot 2021-12-21 at 5 27 34 PM

I've combined the skipped/scheduled into one 'Events' column, that will display skipped or scheduled depending on what's in the /upgrades response. Additionally, the info icon displays the instructions that Ira sent to me when you hover over it. Stats in the Nav Bar is now a dropdown menu.

jarrydallison added a commit that referenced this issue Dec 22, 2021
webbushka added a commit that referenced this issue Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request page Update or add a new/existing page
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants