Remove core.async go-routines from LPM flow #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible for the LPM flow to block, thus making it incompatible with the use of go-routines. We re-tool LPM to use vthreads (when available) which should offer a similar resource consumption model as core.async but without the limitations of blocking. Users on < JDK21 will gracefully degrade to a standard platform thread, which isn't great but its also more correct than leaving LPM using core.async incorrectly. Signed-off-by: Greg Haskins <greg@manetu.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible for the LPM flow to block, thus making it incompatible with the use of go-routines. We re-tool LPM to use vthreads (when available) which should offer a similar resource consumption model as core.async but without the limitations of blocking. Users on < JDK21 will gracefully degrade to a standard platform thread, which isn't great but its also more correct than leaving LPM using core.async incorrectly.