CMake: Enable projects to set the C++ version #10464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change enables projects that consume protobuf via `FetchContent_MakeAvailable()` to set the C++ version to be used. This is necessary, as linking code compiled for different C++ standards is asking for trouble (and will simply not work in some cases). Check that any version that might be set in `CMAKE_CXX_STANDARD` is new enough (C++14 or later). On Cygwin, check if any `-std=gnu++XX` has already been set. In all cases, default to C++14.
|
Friendly ping, is there anything missing? |
|
Hi Christian. Most of the protobuf team was away at an offsite last week so progress on PRs has been slow. Things should start to speed up again now. |
acozzette
approved these changes
Sep 7, 2022
|
@cblichmann Thanks and sorry for the delay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables projects that consume protobuf via
FetchContent_MakeAvailable()to set the C++ version to be used. This isnecessary, as linking code compiled for different C++ standards is asking for
trouble (and will simply not work in some cases).
Check that any version that might be set in
CMAKE_CXX_STANDARDis newenough (C++14 or later). On Cygwin, check if any
-std=gnu++XXhasalready been set. In all cases, default to C++14.