Skip to content

Commit

Permalink
Raise warnings for deprecated python cpp extension GetDebugString().
Browse files Browse the repository at this point in the history
Pure python and upb do not support it and filtered out the test. This API does
not exists in any other language(except protobuf c++).
GetDebugString() for cpp extension will be removed in Jan 2025

PiperOrigin-RevId: 662640110
  • Loading branch information
anandolee committed Aug 13, 2024
1 parent 40b5bda commit 5fc5558
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions python/google/protobuf/pyext/descriptor.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1508,6 +1508,11 @@ static int SetHasOptions(PyFileDescriptor *self, PyObject *value,
}

static PyObject* GetDebugString(PyFileDescriptor* self) {
PyErr_Warn(nullptr,
"GetDebugString() API is deprecated. This API only "
"exists in protobuf c++ and does not exists in pure python, upb "
"or any other languages. GetDebugString() for python cpp "
"extension will be removed in Jan 2025");
return PyString_FromCppString(_GetDescriptor(self)->DebugString());
}

Expand Down

0 comments on commit 5fc5558

Please sign in to comment.