Skip to content

Commit

Permalink
Remove /utf-8 flag added in #14197
Browse files Browse the repository at this point in the history
We have received several reports in #17036 that the addition of this flag
actually broke the use of command argument files with non-ASCII characters in
their names. It looks like #14253 ended up fixing the original issue with a
different solution anyway. Hopefully this change fixes the issue with non-ASCII
characters.

PiperOrigin-RevId: 655660885
  • Loading branch information
acozzette authored and zhangskz committed Jul 25, 2024
1 parent b045935 commit 440dc83
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion build_defs/cpp_opts.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ COPTS = select({
"/wd4506", # no definition for inline function 'function'
"/wd4800", # 'type' : forcing value to bool 'true' or 'false' (performance warning)
"/wd4996", # The compiler encountered a deprecated declaration.
"/utf-8", # Set source and execution character sets to UTF-8
],
"//conditions:default": [
"-DHAVE_ZLIB",
Expand Down

0 comments on commit 440dc83

Please sign in to comment.