Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: reader.skipField is not a function #141

Closed
TA2k opened this issue Oct 8, 2022 · 3 comments · Fixed by #143
Closed

TypeError: reader.skipField is not a function #141

TA2k opened this issue Oct 8, 2022 · 3 comments · Fixed by #143
Assignees
Labels
bug Something isn't working triaged Issue has been triaged

Comments

@TA2k
Copy link

TA2k commented Oct 8, 2022

Since 3.21.1 I receive
TypeError: reader.skipField is not a function

on
deserializeBinary(data).toObject()

with 3.21.0 it is working

Node 16.17.1

@Nihcep
Copy link

Nihcep commented Oct 10, 2022

Same with
reader.readUint64String is not a function
Working with 3.21.0

@dibenede
Copy link
Contributor

This definitely looks like the closure optimizations taking out too much. In the deeper details, all of our tests pass closure deps side, but it looks like our jasmine config for commonjs doesn't include most of our binary/ tests.

@dibenede
Copy link
Contributor

I just published a hotfix release (3.21.2) to npm and will close this out now. Please re-open and ping me if the problem persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triaged Issue has been triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants