Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore optional commas in aggregate options #999

Merged
merged 1 commit into from
Mar 18, 2018

Conversation

drigz
Copy link
Contributor

@drigz drigz commented Mar 15, 2018

More information on the "Aggregate Syntax" here:
protocolbuffers/protobuf#1148

These are accepted by the proto compiler but rarely used - I found an
example in the
Cloud Endpoints docs.

Fixes #383.

More information on the "Aggregate Syntax" here:
protocolbuffers/protobuf#1148

These are accepted by the proto compiler but rarely used - I found an
example in the
[Cloud Endpoints docs](https://cloud.google.com/endpoints/docs/grpc-service-config/reference/rpc/google.api#google.api.HttpRule.FIELDS.string.google.api.HttpRule.rest_method_name).

Fixes protobufjs#383.
@dcodeIO dcodeIO merged commit c05c58f into protobufjs:master Mar 18, 2018
@dcodeIO
Copy link
Member

dcodeIO commented Mar 18, 2018

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants