Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* support default value for map key & value #1087

Conversation

shrimpz
Copy link

@shrimpz shrimpz commented Jul 17, 2018

message TestMap
{
map<int32, int32> x = 1;
}

tm.x[0] = 10;
tm.x[10] = 0;

@alexander-fenster
Copy link
Contributor

@shrimpz I don't feel I really understand the code changes; can you please add some tests that show what exactly the changed code will do? Thanks!

@adriancable
Copy link

@shrimpz (cc: @alexander-fenster) - I'm also stuck by the issue that your pull request fixes. Do you know what happened to it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants