fix tests after Symfony PropertyInfo update

[mringler]

With the current Symfony components, one test in the 5-max and and 6-max group fails, see for example this run.

Apparently, the Symfony PropertyInfo has changed internally, and now an assertion fails. A comment in the test acknowledges that it tests Symfony internals:

        $fictionMetadatas = $fictionMetadata->getPropertyMetadata('isbn');

        // 1st is for ValidateTriggerFiction (base)
        // 2nd is for ValidateTriggerBook (base)
        // I'm not sure if this is needed. We should not care about validator internals
        $this->assertCount(2, $fictionMetadatas);

Examining $fictionMetadatas, I can see that both ValidateTriggerFiction and ValidateTriggerBook are present in $fictionMetadatas[0].constraintsByGroup:

This is also successfully tested in the rest of the test case.

So apparently the PropertyInfo component now groups those constraints in the same PropertyMetadata object instead of using a new object for each. But this does not concern Propel. So we can just remove that assertion. We could also turn it into assertNotEmpty(), but that is tested implicitly in the next assertion.

[codecov-commenter]

Codecov Report

Patch coverage has no change and project coverage change: -1.51 ⚠️

Comparison is base (011aaa7) 88.56% compared to head (d2607c2) 87.05%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #1973      +/-   ##
============================================
- Coverage     88.56%   87.05%   -1.51%     
  Complexity     8051     8051              
============================================
  Files           243      232      -11     
  Lines         24590    24544      -46     
============================================
- Hits          21777    21367     -410     
- Misses         2813     3177     +364     

Flag	Coverage Δ
5-max	87.05% <ø> (-1.51%)	⬇️
7.4	87.05% <ø> (-1.51%)	⬇️
agnostic	67.44% <ø> (+0.14%)	⬆️
mysql	?
pgsql	69.81% <ø> (+0.70%)	⬆️
sqlite	?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 35 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[floriankraemer]

I'll get this merged, it makes sense.