Switch to kingpin flags #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update all of the vendoring for |
|
Fixed! |
SuperQ
approved these changes
Aug 12, 2017
|
Thanks @carlpett! |
oblitorum
pushed a commit
to shatteredsilicon/node_exporter
that referenced
this pull request
Apr 9, 2024
* Switch to kingpin flags * Fix logrus vendoring * Fix flags in main tests * Fix vendoring versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches the flags to be provided by Kingpin, as discussed in prometheus#2455.
Most of it pretty straightforward, but I'd appreciate a check of the things that needed to be done in the tests where previously
flag.Setwas used. Especially the textfile test required pulling in the log package to continue working as before.Note that this is a breaking change, since all flags change.