Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added code to skip RuntimeMXBean attributes #859

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

dhoard
Copy link
Collaborator

@dhoard dhoard commented Jul 27, 2023

Added code to skip RuntimeMXBean attributes SystemProperties, ClassPath, BootClassPath, and LibraryPath since the calls to get the attribute values are very expensive the values are ultimately ignored.

@dhoard dhoard marked this pull request as ready for review July 27, 2023 03:16
@dhoard dhoard requested a review from fstab July 27, 2023 03:17
@dhoard dhoard force-pushed the java-performance-fix branch 2 times, most recently from 456bc05 to ee00fe9 Compare July 27, 2023 03:26
BootClassPath, and LibraryPath since the calls to get the attribute
values are very expensive the values are ultimately ignored

Added code to skip FlightRecorderMXBean since the calls are very
expensive and the values are ultimately ignored

Signed-off-by: Doug Hoard <doug.hoard@gmail.com>
@dhoard dhoard merged commit 08a1515 into prometheus:main Jul 28, 2023
1 check passed
@dhoard dhoard deleted the java-performance-fix branch July 28, 2023 13:41
dhoard added a commit that referenced this pull request Jul 29, 2023
…th, (#859)

BootClassPath, and LibraryPath since the calls to get the attribute
values are very expensive the values are ultimately ignored

Added code to skip FlightRecorderMXBean since the calls are very
expensive and the values are ultimately ignored

Signed-off-by: Doug Hoard <doug.hoard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants