remove dependency to github.com/prometheus/client_golang #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…promhttp (and removing http.go) Signed-off-by: Saeed Rasooli <saeed.gnu@gmail.com>
|
Nevertheless this PR helps avoid dependency hell. |
SuperQ
approved these changes
Jul 14, 2024
|
I think we need a new tag for common to be able to remove client_golang from go.mod |
XSAM
pushed a commit
to XSAM/otelsql
that referenced
this pull request
Aug 27, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/common](https://github.com/prometheus/common) | `v0.55.0` -> `v0.56.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>prometheus/common (github.com/prometheus/common)</summary> ### [`v0.56.0`](https://github.com/prometheus/common/releases/tag/v0.56.0) #### What's Changed - Don't always fetch a OAuth2 token, if the secret from a file didn't change by [@​multani](https://github.com/multani) in [prometheus/common#647 - remove dependency to github.com/prometheus/client_golang by [@​ilius](https://github.com/ilius) in [prometheus/common#662 - Bump github.com/aws/aws-sdk-go from 1.54.7 to 1.54.11 in /sigv4 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#661 - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [prometheus/common#664 - Revert [#​576](https://github.com/prometheus/common/issues/576) and add deprecation notice by [@​SuperQ](https://github.com/SuperQ) in [prometheus/common#665 - Bump golang.org/x/net from 0.26.0 to 0.27.0 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#667 - use basic string in IsValidLegacyMetricName by [@​ywwg](https://github.com/ywwg) in [prometheus/common#668 - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [prometheus/common#672 - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [prometheus/common#674 - Bump github.com/aws/aws-sdk-go from 1.54.19 to 1.55.5 in /sigv4 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#671 - sigv4: support nil body by [@​roidelapluie](https://github.com/roidelapluie) in [prometheus/common#673 - Fix overflows of untyped int constants on 32-bit by [@​dswarbrick](https://github.com/dswarbrick) in [prometheus/common#675 - Update client_golang by [@​SuperQ](https://github.com/SuperQ) in [prometheus/common#676 - Update golangci lint by [@​roidelapluie](https://github.com/roidelapluie) in [prometheus/common#679 - expfmt: Add UTF-8 syntax support in text_parse.go by [@​fedetorres93](https://github.com/fedetorres93) in [prometheus/common#670 - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [prometheus/common#681 - fix(utf8): provide a method for explicitly checking label names for legacy validity by [@​ywwg](https://github.com/ywwg) in [prometheus/common#682 #### New Contributors - [@​multani](https://github.com/multani) made their first contribution in [prometheus/common#647 - [@​ilius](https://github.com/ilius) made their first contribution in [prometheus/common#662 - [@​dswarbrick](https://github.com/dswarbrick) made their first contribution in [prometheus/common#675 - [@​fedetorres93](https://github.com/fedetorres93) made their first contribution in [prometheus/common#670 **Full Changelog**: prometheus/common@v0.55.0...v0.56.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/XSAM/otelsql). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
codeboten
pushed a commit
to open-telemetry/opentelemetry-collector
that referenced
this pull request
Aug 28, 2024
](https://renovatebot.com){kind=link}
) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/common](https://github.com/prometheus/common) | `v0.55.0` -> `v0.56.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>prometheus/common (github.com/prometheus/common)</summary> ### [`v0.56.0`](https://github.com/prometheus/common/releases/tag/v0.56.0) [Compare Source](https://github.com/prometheus/common/compare/v0.55.0...v0.56.0) #### What's Changed - Don't always fetch a OAuth2 token, if the secret from a file didn't change by [@​multani](https://github.com/multani) in [prometheus/common#647 - remove dependency to github.com/prometheus/client_golang by [@​ilius](https://github.com/ilius) in [prometheus/common#662 - Bump github.com/aws/aws-sdk-go from 1.54.7 to 1.54.11 in /sigv4 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#661 - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [prometheus/common#664 - Revert [#​576](https://github.com/prometheus/common/issues/576) and add deprecation notice by [@​SuperQ](https://github.com/SuperQ) in [prometheus/common#665 - Bump golang.org/x/net from 0.26.0 to 0.27.0 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#667 - use basic string in IsValidLegacyMetricName by [@​ywwg](https://github.com/ywwg) in [prometheus/common#668 - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [prometheus/common#672 - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [prometheus/common#674 - Bump github.com/aws/aws-sdk-go from 1.54.19 to 1.55.5 in /sigv4 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#671 - sigv4: support nil body by [@​roidelapluie](https://github.com/roidelapluie) in [prometheus/common#673 - Fix overflows of untyped int constants on 32-bit by [@​dswarbrick](https://github.com/dswarbrick) in [prometheus/common#675 - Update client_golang by [@​SuperQ](https://github.com/SuperQ) in [prometheus/common#676 - Update golangci lint by [@​roidelapluie](https://github.com/roidelapluie) in [prometheus/common#679 - expfmt: Add UTF-8 syntax support in text_parse.go by [@​fedetorres93](https://github.com/fedetorres93) in [prometheus/common#670 - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [prometheus/common#681 - fix(utf8): provide a method for explicitly checking label names for legacy validity by [@​ywwg](https://github.com/ywwg) in [prometheus/common#682 #### New Contributors - [@​multani](https://github.com/multani) made their first contribution in [prometheus/common#647 - [@​ilius](https://github.com/ilius) made their first contribution in [prometheus/common#662 - [@​dswarbrick](https://github.com/dswarbrick) made their first contribution in [prometheus/common#675 - [@​fedetorres93](https://github.com/fedetorres93) made their first contribution in [prometheus/common#670 **Full Changelog**: prometheus/common@v0.55.0...v0.56.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/open-telemetry/opentelemetry-collector). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguNTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIiwicmVub3ZhdGVib3QiXX0=--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
MrAlias
pushed a commit
to open-telemetry/opentelemetry-go-contrib
that referenced
this pull request
Aug 29, 2024
…6059) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/common](https://github.com/prometheus/common) | `v0.55.0` -> `v0.57.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>prometheus/common (github.com/prometheus/common)</summary> ### [`v0.57.0`](https://github.com/prometheus/common/releases/tag/v0.57.0) [Compare Source](https://github.com/prometheus/common/compare/v0.56.0...v0.57.0) #### What's Changed - feat: new promslog and promslog/flag packages to wrap log/slog by [@​tjhop](https://github.com/tjhop) in [prometheus/common#677 #### New Contributors - [@​tjhop](https://github.com/tjhop) made their first contribution in [prometheus/common#677 **Full Changelog**: prometheus/common@v0.56.0...v0.57.0 ### [`v0.56.0`](https://github.com/prometheus/common/releases/tag/v0.56.0) [Compare Source](https://github.com/prometheus/common/compare/v0.55.0...v0.56.0) #### What's Changed - Don't always fetch a OAuth2 token, if the secret from a file didn't change by [@​multani](https://github.com/multani) in [prometheus/common#647 - remove dependency to github.com/prometheus/client_golang by [@​ilius](https://github.com/ilius) in [prometheus/common#662 - Bump github.com/aws/aws-sdk-go from 1.54.7 to 1.54.11 in /sigv4 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#661 - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [prometheus/common#664 - Revert [#​576](https://github.com/prometheus/common/issues/576) and add deprecation notice by [@​SuperQ](https://github.com/SuperQ) in [prometheus/common#665 - Bump golang.org/x/net from 0.26.0 to 0.27.0 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#667 - use basic string in IsValidLegacyMetricName by [@​ywwg](https://github.com/ywwg) in [prometheus/common#668 - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [prometheus/common#672 - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [prometheus/common#674 - Bump github.com/aws/aws-sdk-go from 1.54.19 to 1.55.5 in /sigv4 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#671 - sigv4: support nil body by [@​roidelapluie](https://github.com/roidelapluie) in [prometheus/common#673 - Fix overflows of untyped int constants on 32-bit by [@​dswarbrick](https://github.com/dswarbrick) in [prometheus/common#675 - Update client_golang by [@​SuperQ](https://github.com/SuperQ) in [prometheus/common#676 - Update golangci lint by [@​roidelapluie](https://github.com/roidelapluie) in [prometheus/common#679 - expfmt: Add UTF-8 syntax support in text_parse.go by [@​fedetorres93](https://github.com/fedetorres93) in [prometheus/common#670 - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [prometheus/common#681 - fix(utf8): provide a method for explicitly checking label names for legacy validity by [@​ywwg](https://github.com/ywwg) in [prometheus/common#682 #### New Contributors - [@​multani](https://github.com/multani) made their first contribution in [prometheus/common#647 - [@​ilius](https://github.com/ilius) made their first contribution in [prometheus/common#662 - [@​dswarbrick](https://github.com/dswarbrick) made their first contribution in [prometheus/common#675 - [@​fedetorres93](https://github.com/fedetorres93) made their first contribution in [prometheus/common#670 **Full Changelog**: prometheus/common@v0.55.0...v0.56.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/open-telemetry/opentelemetry-go-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguNTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiU2tpcCBDaGFuZ2Vsb2ciLCJkZXBlbmRlbmNpZXMiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
MrAlias
pushed a commit
to open-telemetry/opentelemetry-go
that referenced
this pull request
Aug 29, 2024
…5748) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/common](https://github.com/prometheus/common) | `v0.55.0` -> `v0.57.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>prometheus/common (github.com/prometheus/common)</summary> ### [`v0.57.0`](https://github.com/prometheus/common/releases/tag/v0.57.0) [Compare Source](https://github.com/prometheus/common/compare/v0.56.0...v0.57.0) #### What's Changed - feat: new promslog and promslog/flag packages to wrap log/slog by [@​tjhop](https://github.com/tjhop) in [prometheus/common#677 #### New Contributors - [@​tjhop](https://github.com/tjhop) made their first contribution in [prometheus/common#677 **Full Changelog**: prometheus/common@v0.56.0...v0.57.0 ### [`v0.56.0`](https://github.com/prometheus/common/releases/tag/v0.56.0) [Compare Source](https://github.com/prometheus/common/compare/v0.55.0...v0.56.0) #### What's Changed - Don't always fetch a OAuth2 token, if the secret from a file didn't change by [@​multani](https://github.com/multani) in [prometheus/common#647 - remove dependency to github.com/prometheus/client_golang by [@​ilius](https://github.com/ilius) in [prometheus/common#662 - Bump github.com/aws/aws-sdk-go from 1.54.7 to 1.54.11 in /sigv4 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#661 - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [prometheus/common#664 - Revert [#​576](https://github.com/prometheus/common/issues/576) and add deprecation notice by [@​SuperQ](https://github.com/SuperQ) in [prometheus/common#665 - Bump golang.org/x/net from 0.26.0 to 0.27.0 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#667 - use basic string in IsValidLegacyMetricName by [@​ywwg](https://github.com/ywwg) in [prometheus/common#668 - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [prometheus/common#672 - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [prometheus/common#674 - Bump github.com/aws/aws-sdk-go from 1.54.19 to 1.55.5 in /sigv4 by [@​dependabot](https://github.com/dependabot) in [prometheus/common#671 - sigv4: support nil body by [@​roidelapluie](https://github.com/roidelapluie) in [prometheus/common#673 - Fix overflows of untyped int constants on 32-bit by [@​dswarbrick](https://github.com/dswarbrick) in [prometheus/common#675 - Update client_golang by [@​SuperQ](https://github.com/SuperQ) in [prometheus/common#676 - Update golangci lint by [@​roidelapluie](https://github.com/roidelapluie) in [prometheus/common#679 - expfmt: Add UTF-8 syntax support in text_parse.go by [@​fedetorres93](https://github.com/fedetorres93) in [prometheus/common#670 - Synchronize common files from prometheus/prometheus by [@​prombot](https://github.com/prombot) in [prometheus/common#681 - fix(utf8): provide a method for explicitly checking label names for legacy validity by [@​ywwg](https://github.com/ywwg) in [prometheus/common#682 #### New Contributors - [@​multani](https://github.com/multani) made their first contribution in [prometheus/common#647 - [@​ilius](https://github.com/ilius) made their first contribution in [prometheus/common#662 - [@​dswarbrick](https://github.com/dswarbrick) made their first contribution in [prometheus/common#675 - [@​fedetorres93](https://github.com/fedetorres93) made their first contribution in [prometheus/common#670 **Full Changelog**: prometheus/common@v0.55.0...v0.56.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/open-telemetry/opentelemetry-go). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguNTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiU2tpcCBDaGFuZ2Vsb2ciLCJkZXBlbmRlbmNpZXMiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove dependency to
github.com/prometheus/client_golangclient_golangdepends on this module, so it doesn't make sense for this module to depend onclient_golang.This can cause
go.sumfile of user repos to be very very large and make it very slow to download deps and build.Also makes it much harder to fork these two modules.
It's just a design problem.