Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken benchmarks #49

Merged
merged 1 commit into from
Aug 1, 2016
Merged

Fix broken benchmarks #49

merged 1 commit into from
Aug 1, 2016

Conversation

lmb
Copy link
Contributor

@lmb lmb commented Jul 26, 2016

Re-creates the protobuf file from the text definition, and re-compresses both text and protobuf files.

Found this while working on #48. Without this change, text.gz is missing, protobuf.gz broken and the protobuf definition outdated.

PASS
BenchmarkParseText-4                    2000        886160 ns/op
BenchmarkParseTextGzip-4            --- FAIL: BenchmarkParseTextGzip-4
    bench_test.go:73: open testdata/text.gz: no such file or directory
BenchmarkParseProto-4               --- FAIL: BenchmarkParseProto-4
    bench_test.go:111: proto: can't skip unknown wire type 7 for io_prometheus_client.MetricFamily
BenchmarkParseProtoGzip-4           --- FAIL: BenchmarkParseProtoGzip-4
    bench_test.go:131: gzip: invalid header
BenchmarkParseProtoMap-4            --- FAIL: BenchmarkParseProtoMap-4
    bench_test.go:166: proto: can't skip unknown wire type 7 for io_prometheus_client.MetricFamily
BenchmarkDiscriminatorHTTPHeader-4    100000         19813 ns/op
BenchmarkCreate-4                      20000         65743 ns/op
BenchmarkCreateError-4                100000         12259 ns/op
BenchmarkTextParse-4                    5000        301804 ns/op
BenchmarkParseError-4                  30000         51406 ns/op
ok      github.com/prometheus/common/expfmt 11.032s

Re-creates the protobuf file from the text definition, and re-compresses both text and protobuf files.
@beorn7
Copy link
Member

beorn7 commented Aug 1, 2016

Great. Thank you. And sorry for the wait.

@beorn7 beorn7 merged commit ebdfc6d into prometheus:master Aug 1, 2016
gouthamve pushed a commit to gouthamve/common that referenced this pull request Jul 22, 2018
35679ee Merge pull request prometheus#110 from weaveworks/parallel-push-errors
3ae41b6 Remove unneeded if block
51ff31a Exit on first error
0faad9f Check for errors when pushing images in parallel
74dc626 Merge pull request prometheus#108 from weaveworks/disable-apt-daily
b4f1d91 Merge pull request prometheus#107 from weaveworks/docker-17-update
7436aa1 Override apt daily job to not run immediately on boot
7980f15 Merge pull request prometheus#106 from weaveworks/document-docker-install-role
f741e53 Bump to Docker 17.06 from CE repo
61796a1 Update Docker CE Debian repo details
0d86f5e Allow for Docker package to be named docker-ce
065c68d Document selection of Docker installation role.
3809053 Just --porcelain; it defaults to v1
11400ea Merge pull request prometheus#105 from weaveworks/remove-weaveplugin-remnants
b8b4d64 remove weaveplugin remnants
35099c9 Merge pull request prometheus#104 from weaveworks/pull-docker-py
cdd48fc Pull docker-py to speed tests/builds up.
e1c6c24 Merge pull request prometheus#103 from weaveworks/test-build-tags
d5d71e0 Add -tags option so callers can pass in build tags
8949b2b Merge pull request prometheus#98 from weaveworks/git-status-tag
ac30687 Merge pull request prometheus#100 from weaveworks/python_linting
4b125b5 Pin yapf & flake8 versions
7efb485 Lint python linting function
444755b Swap diff direction to reflect changes required
c5b2434 Install flake8 & yapf
5600eac Lint python in build-tools repo
0b02ca9 Add python linting
c011c0d Merge pull request prometheus#79 from kinvolk/schu/python-shebang
6577d07 Merge pull request prometheus#99 from weaveworks/shfmt-version
00ce0dc Use git status instead of diff to add 'WIP' tag
411fd13 Use shfmt v1.3.0 instead of latest from master.
0d6d4da Run shfmt 1.3 on the code.
5cdba32 Add sudo
c322ca8 circle.yml: Install shfmt binary.
e59c225 Install shfmt 1.3 binary.
30706e6 Install pyhcl in the build container.
960d222 Merge pull request prometheus#97 from kinvolk/alban/update-shfmt-3
1d535c7 shellcheck: fix escaping issue
5542498 Merge pull request prometheus#96 from kinvolk/alban/update-shfmt-2
32f7cc5 shfmt: fix coding style
09f72af lint: print the diff in case of error
571c7d7 Merge pull request prometheus#95 from kinvolk/alban/update-shfmt
bead6ed Update for latest shfmt
b08dc4d Update for latest shfmt (prometheus#94)
2ed8aaa Add no-race argument to test script (prometheus#92)
80dd78e Merge pull request prometheus#91 from weaveworks/upgrade-go-1.8.1
08dcd0d Please ./lint as shfmt changed its rules between 1.0.0 and 1.3.0.
a8bc9ab Upgrade default Go version to 1.8.1.
31d069d Change Python shebang to `#!/usr/bin/env python`

git-subtree-dir: tools
git-subtree-split: 35679ee5ff17c4edf864b7c43dc70a40337fcd80
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants