BREAKING: Remove redirect from unknown paths to /metrics #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlpett
force-pushed
the
remove-redirect
branch
from
c921a28
to
1a2f003
Compare
carlpett
force-pushed
the
remove-redirect
branch
from
1a2f003
to
df954dd
Compare
martinlindhe
approved these changes
Mar 28, 2020
anubhavg-icpl
pushed a commit
to anubhavg-icpl/windows_exporter
that referenced
this pull request
Sep 22, 2024
…redirect BREAKING: Remove redirect from unknown paths to /metrics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the redirect from any unhandled path to /metrics. This behaviour has been with us since the beginning, but I'd like to finally remove it.
This will break any existing installs that has assumptions about this, but do not set the
--telemetry.pathflag to whatever path they use.