Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installer: Add UI + Add default config file + Replace ADD_FIREWALL_EXCEPTION with ADDLOCAL=FirewallException #1611

Merged
merged 4 commits into from
Sep 6, 2024

Conversation

jkroepke
Copy link
Member

@jkroepke jkroepke commented Sep 6, 2024

Fixes #1609
Fixes #1261
Fixes #1466

This PR add an installer UI and forces reinstalling features on reinstall.

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
@jkroepke jkroepke requested a review from a team as a code owner September 6, 2024 10:39
Signed-off-by: Jan-Otto Kröpke <github@jkroepke.de>
@jkroepke jkroepke changed the title installer: Add UI installer: Add UI + Replace ADD_FIREWALL_EXCEPTION with ADDLOCAL=FirewallException Sep 6, 2024
@jkroepke jkroepke changed the title installer: Add UI + Replace ADD_FIREWALL_EXCEPTION with ADDLOCAL=FirewallException installer: Add UI + Replace ADD_FIREWALL_EXCEPTION with ADDLOCAL=FirewallException Sep 6, 2024
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
@jkroepke jkroepke merged commit b3c0c58 into prometheus-community:master Sep 6, 2024
5 checks passed
@jkroepke jkroepke deleted the installer branch September 6, 2024 20:29
@jkroepke jkroepke changed the title installer: Add UI + Replace ADD_FIREWALL_EXCEPTION with ADDLOCAL=FirewallException installer: Add UI + Add default config file + Replace ADD_FIREWALL_EXCEPTION with ADDLOCAL=FirewallException Sep 7, 2024
anubhavg-icpl pushed a commit to anubhavg-icpl/windows_exporter that referenced this pull request Sep 22, 2024
astigmata pushed a commit to astigmata/windows_exporter that referenced this pull request Sep 26, 2024
…irewallException` (prometheus-community#1611)

Signed-off-by: astigmata <envoiici@gmail.com>
astigmata pushed a commit to astigmata/windows_exporter that referenced this pull request Sep 26, 2024
…irewallException` (prometheus-community#1611)

Signed-off-by: astigmata <envoiici@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant