Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cs: Deprecate collector + os: Deprecate metrics [memory metrics moved to memory collector] (click PR for more information) #1596

Merged
merged 25 commits into from
Aug 31, 2024

Conversation

jkroepke
Copy link
Member

@jkroepke jkroepke commented Aug 30, 2024

Fixes #1593

cs collector metrics

The metrics still exists, but moved to other collectors,

Old Metric New Metric
windows_cs_hostname windows_os_hostname
windows_cs_physical_memory_bytes windows_memory_physical_free_bytes
windows_cs_logical_processors windows_cpu_logical_processor

os collector metrics

Old Metric New Metric
windows_os_time windows_time_current_timestamp_seconds
windows_os_timezone windows_time_timezone
windows_os_users count(windows_logon_logon_type)
windows_os_physical_memory_free_bytes windows_memory_physical_free_bytes
windows_os_process_memory_limit_bytes windows_memory_process_memory_limit_bytes
windows_os_virtual_memory_free_bytes windows_memory_commit_limit - windows_memory_committed_bytes
windows_os_visible_memory_bytes windows_memory_physical_total_bytes
windows_os_virtual_memory_bytes windows_memory_commit_limit
windows_os_processes_limit windows_system_process_limit
windows_os_processes windows_system_processes

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
@jkroepke jkroepke requested a review from a team as a code owner August 30, 2024 22:13
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
@jkroepke jkroepke changed the title cs: Deprecate collector + os: Deprecate metrics cs: Deprecate and disable collector by default + os: Deprecate metrics Aug 30, 2024
@jkroepke jkroepke changed the title cs: Deprecate and disable collector by default + os: Deprecate metrics cs: Deprecate and disable collector by default + os: Deprecate metrics (click PR for more information) Aug 30, 2024
jkroepke and others added 9 commits August 31, 2024 00:21
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <github@jkroepke.de>
@jkroepke jkroepke changed the title cs: Deprecate and disable collector by default + os: Deprecate metrics (click PR for more information) cs: Deprecate and disable collector by default + os: Deprecate metrics [memory metrics moved to memory collector] (click PR for more information) Aug 31, 2024
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
@jacbo0112
Copy link
Contributor

This action has a significant impact

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
@jkroepke
Copy link
Member Author

jkroepke commented Aug 31, 2024

This action has a significant impact

@jacbo0112 I'm aware of this. And I this PR does not remove any metrics. The old metrics remains. It's not an breaking change. I do breaking change on other, less important collectors. But for the core metrics, I will keep some grace period.

Only the documentation for the old metrics will be disappear and mark a deprecated. The plan is to remove them mid-2025.

But before this exporter hits 1.0, some actions are mandatory.

There is an cs collector which expose cpu and memory metrics. there is an os collector which expose memory metrics. And there is an memory metrics which exposes metrics.

It's chaos.

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
@jkroepke jkroepke changed the title cs: Deprecate and disable collector by default + os: Deprecate metrics [memory metrics moved to memory collector] (click PR for more information) cs: Deprecate collector + os: Deprecate metrics [memory metrics moved to memory collector] (click PR for more information) Aug 31, 2024
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
@jkroepke jkroepke changed the base branch from master to next August 31, 2024 18:11
@jkroepke jkroepke merged commit 717f8d4 into prometheus-community:next Aug 31, 2024
8 checks passed
@jkroepke jkroepke deleted the cs branch August 31, 2024 18:11
@jacbo0112
Copy link
Contributor

此操作具有重大影响

我知道这一点。而且我这个 PR 没有删除任何指标。旧指标仍然存在。这不是一个突破性的变化。我对其他不太重要的收藏家进行重大更改。但对于核心指标,我将保留一些宽限期。

只有旧指标的文档才会消失并标记为已弃用。计划在 2025 年年中移除它们。

但在此导出程序达到 1.0 之前,某些操作是强制性的。

有一个 cs 收集器,用于公开 cpu 和内存指标。有一个 OS 收集器,用于公开内存指标。还有一个 memory metrics 公开了 metrics。

这是混乱的。

There are no issues with the corresponding product design. It is important to carefully consider changes in indicator names and confirm them all at once after careful consideration to avoid repeated name changes in the future

@jacbo0112
Copy link
Contributor

My understanding of the windows_time collector is that it is used to obtain Windows time service metrics. But window_os_time checks the Windows time. Windows_os_timezone is used to view the time zone of Windows. Will migrating these two metrics to the Windows time collector result in only requiring the operating system's time and time zone, and requiring a separate collector to be enabled

@jkroepke
Copy link
Member Author

jkroepke commented Sep 2, 2024

Thats fully correct. Any time related metric is now inside time collector. The scope is increased. If you care about time on your system, you might be interest into time service metrics as well. If you need the timezone metric, you habe to enable time collector. Thats the design choice. Splitt large generic collector.

Another example is the process_count: It information was collected (but not exposed) in the system collector as well, while the thread count metrics remains on system collector.

The paging information inside the os collector will be moved to an separated paging collector as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

logical processor metric output is not matching with server
2 participants