Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add stale action #1342

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Conversation

jkroepke
Copy link
Member

windows_exporter has a lot of opened issue with may not longer interest. I would like to cleanup some of the approx 300 issues and staled PRs.

This action uses https://github.com/actions/stale . After 90 days of inactivity, a post will be written from gh actions. After another 30 days of interactivity, the issue will be closed.

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
@jkroepke jkroepke requested a review from a team as a code owner November 17, 2023 18:04
@breed808
Copy link
Contributor

I had considered adding this action some time back, but couldn't decide on appropriate timings. Too low and it adds a burden on users raising the issues, which might discourage users from submitting/updating issues. I also want to avoid this tool resulting in issue duplicates (user creates issue with information, bot closes issue, new user creates new issue missing information from the first issue).

I'd be in favour of introducing this with larger timings, such as 6 months before marking as stale, and a 2-3 month duration before closing issues after that. Does that seem reasonable?

@jkroepke
Copy link
Member Author

Them times that I choiced here based on large projects like https://github.com/helm/helm

90/30 that are 3 months + 1 months. I guess there is an inactivity for 3 months, its already stale from my point of view.

Mention that after 120 days of interactivity, users still can post to closed issues and ask for reopen, because the issues are not locked.

special issues can have a lifecycle/frozen label. That excludes tickets from state action.

I feel 180/90 days a bit to long. If the bot posts the stale warning, its unliky that users will posts after 2-3 weeks. Mostly, they react in the first 2 weeks.

@breed808
Copy link
Contributor

Just to clarify, would issues closed by this proposed action be locked?

@jkroepke
Copy link
Member Author

Example: helm/helm#9293

No locking, just closing.

Copy link
Contributor

@breed808 breed808 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, as we're not preventing users from re-opening tickets I'm happy to proceed with this.

We can always tweak the timings later depending on user feedback.

@jkroepke jkroepke merged commit e9feac8 into prometheus-community:master Nov 20, 2023
2 checks passed
@jkroepke jkroepke deleted the action/stale branch November 20, 2023 18:30
anubhavg-icpl pushed a commit to anubhavg-icpl/windows_exporter that referenced this pull request Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants