Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not abort if we do not know which user is running the process #1336

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Do not abort if we do not know which user is running the process #1336

merged 1 commit into from
Nov 14, 2023

Conversation

kang-makes
Copy link
Contributor

There are a few cases when we want the exporter to run without knowing which user is running it that may fail because of the issue golang/go#37348

This PR prints a warning instead of aborting.

@kang-makes kang-makes requested a review from a team as a code owner November 14, 2023 16:13
Signed-off-by: Juan Manuel Perez <jperezflorez@newrelic.com>
Copy link
Member

@jkroepke jkroepke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thanks for your contribution.

@jkroepke jkroepke merged commit 84eadf5 into prometheus-community:master Nov 14, 2023
5 checks passed
@kang-makes kang-makes deleted the fix/dont-abort-user-is-nil branch November 15, 2023 11:11
anubhavg-icpl pushed a commit to anubhavg-icpl/windows_exporter that referenced this pull request Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants