Add physical_disk collector #1251
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rob Scheepens <rob.scheepens@nutanix.com> Signed-off-by: Brantley West <brantley@nutanix.com>
Signed-off-by: Rob Scheepens <rob.scheepens@nutanix.com> Signed-off-by: Brantley West <brantley@nutanix.com>
Signed-off-by: Rob Scheepens <rob.scheepens@nutanix.com>
breed808
requested changes
Aug 20, 2023
| @@ -49,7 +49,7 @@ type prometheusVersion struct { | |||
| } | |||
|
|
|||
| const ( | |||
| defaultCollectors = "cpu,cs,logical_disk,net,os,service,system,textfile" | |||
| defaultCollectors = "cpu,cs,logical_disk,physical_disk,net,os,service,system,textfile" | |||
There was a problem hiding this comment.
Does it make sense to have both the logical_disk and physical_disk collectors enabled by default? That is, do the metrics exposed by both collectors overlap in scope?
Comment on lines
+26
to
+36
| `requests_queued` | Number of requests outstanding on the disk at the time the performance data is collected | gauge | `disk` | ||
| `read_bytes_total` | Rate at which bytes are transferred from the disk during read operations | counter | `disk` | ||
| `reads_total` | Rate of read operations on the disk | counter | `disk` | ||
| `write_bytes_total` | Rate at which bytes are transferred to the disk during write operations | counter | `disk` | ||
| `writes_total` | Rate of write operations on the disk | counter | `disk` | ||
| `read_seconds_total` | Seconds the disk was busy servicing read requests | counter | `disk` | ||
| `write_seconds_total` | Seconds the disk was busy servicing write requests | counter | `disk` | ||
| `free_bytes` | Unused space of the disk in bytes (not real time, updates every 10-15 min) | gauge | `disk` | ||
| `size_bytes` | Total size of the disk in bytes (not real time, updates every 10-15 min) | gauge | `disk` | ||
| `idle_seconds_total` | Seconds the disk was idle (not servicing read/write requests) | counter | `disk` | ||
| `split_ios_total` | Number of I/Os to the disk split into multiple I/Os | counter | `disk` |
There was a problem hiding this comment.
Can you add the prefix to the documented metrics? E.G. windows_physical_disk_requests_queued
| ) | ||
|
|
||
| func init() { | ||
| registerCollector("physical_disk", NewPhysicalDiskCollector, "PhysicalDisk") |
There was a problem hiding this comment.
The init() function will need to be removed, with collector registration details moved to init.go. I'm happy to make this change if you like.
There was a problem hiding this comment.
Hi Ben, yes please make this change for me if you could.
Comment on lines
+22
to
+27
| "collector.physical_disk.disk-whitelist", | ||
| "Regexp of disks to whitelist. Disk name must both match whitelist and not match blacklist to be included.", | ||
| ).Default(".+").String() | ||
| diskBlacklist = kingpin.Flag( | ||
| "collector.physical_disk.disk-blacklist", | ||
| "Regexp of disks to blacklist. Disk name must both match whitelist and not match blacklist to be included.", |
There was a problem hiding this comment.
Can we change the flag names from whitelist and blacklist to include and exclude, respectively?
See #679 for context.
|
Closing in favor of #803. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the physical_disk collector, based on the logical_disk collector. This is a result from the request in #795 (comment).